Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test requirements, upgrade black #437

Merged
merged 9 commits into from
Feb 19, 2024
Merged

Add test requirements, upgrade black #437

merged 9 commits into from
Feb 19, 2024

Conversation

araffin
Copy link
Member

@araffin araffin commented Feb 19, 2024

Description

closes #435
closes #436

@power-edge for some reasons, I couldn't push my edits to your branch...

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)

Note: we are using a maximum length of 127 characters per line

@araffin araffin mentioned this pull request Feb 19, 2024
12 tasks
@araffin araffin merged commit aa38145 into master Feb 19, 2024
8 checks passed
@araffin araffin deleted the chore/test-deps branch February 19, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TODO: add test dependencies in the setup.py
2 participants