Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test requirements, upgrade black #436

Closed
wants to merge 7 commits into from
Closed

Conversation

power-edge
Copy link

@power-edge power-edge commented Feb 18, 2024

  • adding test requirements per failing tests with missing dependencies
  • ignoring virtual environment
  • auto-format some files with black .

Description

I saw the # TODO: add test dependencies in the setup.py so I went ahead and captured missing dependencies while running tests.

Motivation and Context

#435

closes #435

closes [Bug]: TODO: add test dependencies in the setup.py #435 #435

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • [?] My change requires a change to the documentation.
    • would understand if the additional documentation is deemed not necessary
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)

image

I had already fixed the pytablewriter requirement for test_benchmark as of this screenshot

Now after adding test requirements, there is only one failure (and it is not related to missing erquirement)
image

Note: we are using a maximum length of 127 characters per line

@power-edge
Copy link
Author

This is the only remaining test failure
image

@araffin araffin changed the title adding test requirements, ignoring virtual env, and ran 'black .' to auto format files Add test requirements, upgrade black Feb 19, 2024
@araffin araffin mentioned this pull request Feb 19, 2024
13 tasks
@araffin
Copy link
Member

araffin commented Feb 19, 2024

Thanks =) I've pushed my edits there: #437

For the full tests, you need to use -r requirements.txt (as in the readme and doc), I remove the readme in the test folder to avoid scattering documentation across too many files.

@araffin araffin closed this in #437 Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TODO: add test dependencies in the setup.py
3 participants