Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/do now swallow exceptions during verify #141

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Aug 20, 2024

  1. Remove unused parameters from constructor

    Eliminated the utcDataService and signatureService parameters from the SecuredOnboardingService constructor as they were no longer in use. This cleanup helps streamline the code and improve readability.
    saschadoemer committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    ef9c3cb View commit details
    Browse the repository at this point in the history
  2. Rename exception base class to include verification logic

    Renamed OnboardRevokeExceptionBase to OnboardRevokeOrVerifyExceptionBase to better reflect its purpose. Updated all derived exception classes to inherit from the new base class.
    saschadoemer committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    d92e00b View commit details
    Browse the repository at this point in the history
  3. Simplify error handling in SecuredOnboardingService

    Replaced the detailed switch-case error handling with a more concise deserialization of error responses using OnboardErrorResponse class. This change improves readability and maintainability by centralizing error message construction within the OnboardException.
    saschadoemer committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    8d36abf View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Configuration menu
    Copy the full SHA
    c196122 View commit details
    Browse the repository at this point in the history