Bugfix/do now swallow exceptions during verify #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminated the utcDataService and signatureService parameters from the SecuredOnboardingService constructor as they were no longer in use. This cleanup helps streamline the code and improve readability.
Renamed OnboardRevokeExceptionBase to OnboardRevokeOrVerifyExceptionBase to better reflect its purpose. Updated all derived exception classes to inherit from the new base class.
Replaced the detailed switch-case error handling with a more concise deserialization of error responses using OnboardErrorResponse class. This change improves readability and maintainability by centralizing error message construction within the OnboardException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.