[2124] Reduce length of Bigquery service account name

[saliceti]

Context

Fix for error in TRS preprod:

Error: "account_id" ("appender-wif-trs-pre-production") doesn't match regexp "^[a-z](?:[-a-z0-9]{4,28}[a-z0-9])$"

Changes proposed in this pull request

Change the service account name to allow longer environment names

Guidance to review

Run terraform plan on DFE-Digital/teaching-record-system#1681

  # module.dfe_analytics[0].google_service_account.appender will be created
  + resource "google_service_account" "appender" {
      + account_id   = "app-wif-trs-pre-production"
      + description  = "Configured with workflow identity federation from Azure"
      + disabled     = false
      + display_name = "Service Account appender to trs in pre-production environment"
  ...

Checklist

• I have performed a self-review of my code, including formatting and typos
• I have cleaned the commit history
• I have added the Devops label
• I have attached the pull request to the trello card

[saliceti]

TRS: migrate to GCP WIF

[neillturner]

on the branch i ran:
gcloud auth application-default login
and logged on to my google education.gov.uk account
ran
make test terraform-plan
with
docker_image
set to ghcr.io/dfe-digital/teaching-record-system:714e65ed812b076557cb0c26165a9369c0a771f9
and get
No changes. Your infrastructure matches the configuration.
so change has worked