Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2124] Migrate preprod to GCP WIF #1681

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Nov 15, 2024

Context

Migrate all environments one by one to Google bigquery with workload identity federation

⚠️ This depends on PR DFE-Digital/terraform-modules#132. It must be released to testing first

Changes proposed in this pull request

Enable gcp wif on the preprod environment

Guidance to review

Compare with the test environment

Before merging

Update the SharedConfig secret in the s189t01-trs-pp-inf-kv keyvault: remove the DfeAnalytics key

Checklist

  • Attach to Trello card
  • Rebased master
  • Cleaned commit history
  • Tested by running locally
  • Run DQT integration tests locally (if appropriate)

@saliceti
Copy link
Member Author

TRS: migrate to GCP WIF

@saliceti saliceti force-pushed the 2124-trs-migrate-to-gcp-wif-preprod branch from d10b51d to 90023be Compare November 18, 2024 12:24
@saliceti saliceti enabled auto-merge (squash) November 18, 2024 12:30
@saliceti saliceti merged commit 83f1ba8 into main Nov 18, 2024
18 checks passed
@saliceti saliceti deleted the 2124-trs-migrate-to-gcp-wif-preprod branch November 18, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants