Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ayy1 incorrect announcements #7320

Merged
merged 5 commits into from
Dec 11, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,17 @@
p.govuk-body = t(".one_login_banner.paragraph2")

span.govuk-caption-l = t("jobseekers.job_applications.caption", job_title: vacancy.job_title, organisation: vacancy.organisation_name)
h2.govuk-heading-xl = t("jobseekers.job_applications.heading")
h1.govuk-heading-xl = t("jobseekers.job_applications.heading")

.govuk-grid-row
.govuk-grid-column-two-thirds
h1.govuk-heading-l = t(".heading")
h2.govuk-heading-l = t(".heading")
p.govuk-body = (@has_previous_application ? t(".description1") : t(".description1_profile"))
p.govuk-body = t(".description2")
p.govuk-body = t(".description3")
p.govuk-body = t(".save_and_return")
= govuk_button_to t("buttons.start_application"), quick_apply_jobseekers_job_job_application_path(vacancy.id)

.govuk-grid-column-one-third
h2.govuk-heading-m = t(".assistance.heading")
.govuk-heading-m = t(".assistance.heading")
p.govuk-body-s = t(".assistance.content_html", privacy_html: govuk_link_to(t(".assistance.privacy"), "https://www.gov.uk/government/publications/privacy-information-education-providers-workforce-including-teachers/privacy-information-education-providers-workforce-including-teachers"), terms_html: govuk_link_to(t(".assistance.terms"), page_path("terms-and-conditions")))
14 changes: 7 additions & 7 deletions app/views/jobseekers/profiles/_summary.html.slim
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ p class="govuk-!-margin-bottom-3" = jobseeker_status(profile)

- if (job_preferences = profile.job_preferences).present?

h2.govuk-heading-m class="govuk-!-margin-bottom-5"
scruti marked this conversation as resolved.
Show resolved Hide resolved
.govuk-heading-m class="govuk-!-margin-bottom-5"
= t(".job_preferences")
= govuk_summary_list do |summary_list|
- if (roles = job_preferences.roles).present?
Expand All @@ -27,11 +27,11 @@ p class="govuk-!-margin-bottom-3" = jobseeker_status(profile)
- row.with_value text: humanize_array(patterns)

- if profile.about_you.present?
h2.govuk-heading-m class="govuk-!-padding-bottom-2"
.govuk-heading-m class="govuk-!-padding-bottom-2"
= t(".about")
p = simple_format profile.about_you

h2.govuk-heading-m class="govuk-!-padding-bottom-3"
.govuk-heading-m class="govuk-!-padding-bottom-3"
= t(".contact_details")
dl.govuk-summary-list
.govuk-summary-list__row
Expand All @@ -43,7 +43,7 @@ dl.govuk-summary-list
dd.govuk-summary-list__value = phone_number

- if profile.employments.any?
h2.govuk-heading-m = t(".work_history")
.govuk-heading-m = t(".work_history")
- profile.employments.order(:started_on).reverse_each do |employment|
h3.govuk-heading-s class="govuk-!-padding-bottom-0 govuk-!-margin-bottom-0"
= employment.organisation
Expand All @@ -55,13 +55,13 @@ dl.govuk-summary-list
hr.govuk-section-break.govuk-section-break--s.govuk-section-break--visible[class=class_name]

- if profile.qualifications.any?
h2.govuk-heading-m class="govuk-!-padding-bottom-3" = t(".qualifications")
.govuk-heading-m class="govuk-!-padding-bottom-3" = t(".qualifications")
= render "jobseekers/qualifications/preview_qualifications", qualifications: profile.qualifications

- if profile.training_and_cpds.any?
h2.govuk-heading-m class="govuk-!-padding-bottom-3" = t(".training_and_cpd")
.govuk-heading-m class="govuk-!-padding-bottom-3" = t(".training_and_cpd")
- profile.training_and_cpds.each do |training|
h3.govuk-heading-s class="govuk-!-padding-bottom-0"
.govuk-heading-s class="govuk-!-padding-bottom-0"
= training.name
- if training.grade
p class="govuk-body govuk-!-margin-bottom-0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@

sign_in_jobseeker_govuk_one_login(jobseeker)
expect(current_path).to eq(new_quick_apply_jobseekers_job_job_application_path(vacancy.id))
expect(page).to have_css("h1", text: I18n.t("jobseekers.job_applications.new_quick_apply.heading"))
expect(page).to have_css("h2", text: I18n.t("jobseekers.job_applications.new_quick_apply.heading"))
end
end
end
Loading