Ayy1 incorrect announcements #7320
Open
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddippolito
force-pushed
the
ayy1-incorrect-announcements
branch
2 times, most recently
from
d06ff20
to
dea557d
Compare
ddippolito
force-pushed
the
ayy1-incorrect-announcements
branch
from
dea557d
to
15548a4
Compare
|
Review app deployed to https://teaching-vacancies-review-pr-7320.test.teacherservices.cloud on AKS |
scruti
reviewed
Nov 29, 2024
| @@ -2,7 +2,7 @@ p class="govuk-!-margin-bottom-3" = jobseeker_status(profile) | |||
|
|
|||
| - if (job_preferences = profile.job_preferences).present? | |||
|
|
|||
| h2.govuk-heading-m class="govuk-!-margin-bottom-5" | |||
There was a problem hiding this comment.
I don't think these headers should be removed or are the "separators" the ticket description refers to. The ticket seems to infer that non-title separator elements that shouldn't be focusable are implemented as heading 2.
There was a problem hiding this comment.
The page doesn't change with an h2 or without for each element.
I'm not able to determine if the h2 provides a semantic meaning or it was used for styling purposes.
I'm happy to move it back.
starswan
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/NI05B9BN/1432-a11y-412-name-role-value-incorrect-announcements-x
Changes in this PR:
Fixes announcements issues for ayy1 purposes on the quick apply page and on the candidate profile page