Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend content in Visas cannot be sponsored dropdown #4807

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Amend content in Visas cannot be sponsored dropdown #4807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d3f9b3
Amend content in Visas cannot be sponsored dropdown
gms-gs Jan 9, 2025
a56a732
Update spec
gms-gs Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions app/components/find/courses/international_students_component/view.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
EEA, Switzerland, Gibraltar, or the UK for at least the previous 3 years will also be eligible.</p>
<% end %>

<p class="govuk-body"><%= apprenticeship? ? "You’ll also" : "You’ll" %> need the <%= right_required %> in the UK</p>
<p class="govuk-body"><%= apprenticeship? ? "You’ll also" : "You’ll" %> need the <%= right_required %> in the UK.</p>

<p class="govuk-body">You already have this if, for example, you:</p>

Expand All @@ -19,11 +19,13 @@
<li>have indefinite leave to remain in the UK</li>
</ul>

<%= t(
"find.international_candidates.#{visa_type}.#{sponsorship_availability}.html",
provider_url: x_provider_url
) %>
<% unless visa_type == :student_visa && sponsorship_availability != :available %>
<%= t(
"find.international_candidates.#{visa_type}.#{sponsorship_availability}.html",
provider_url: x_provider_url
) %>
<% end %>
gms-gs marked this conversation as resolved.
Show resolved Hide resolved

<p class="govuk-body">Learn more about <%= govuk_link_to("training to teach in England as an international student", t("find.get_into_teaching.url_train_to_teach_as_international_candidate")) %>.</p>
<p class="govuk-body">Learn more about <%= govuk_link_to("training to teach in England as a non-UK citizen", t("find.get_into_teaching.url_train_to_teach_as_international_candidate")) %>.</p>
</div>
<% end %>
2 changes: 0 additions & 2 deletions config/locales/find.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,6 @@ en:
<p class="govuk-body">To do this, you’ll need to be sponsored by your employer.</p>
<p class="govuk-body">Before you apply for this course, <a class="govuk-link" href=%{provider_url}>contact the training provider</a> to check Skilled Worker visa sponsorship is available. If it is, and you get a place on this course, we’ll help you apply for your visa.</p>
student_visa:
not_available:
html: <p class="govuk-body">If you do not already have the right to study in the UK, you may need to <a class="govuk-link" href="https://getintoteaching.education.gov.uk/non-uk-teachers/visas-for-non-uk-trainees"> apply for your visa to train to teach in England</a>.</p>
available:
html:
<p class="govuk-body">If you do not already have the right to study in the UK, you may need to <a class="govuk-link" href="https://getintoteaching.education.gov.uk/non-uk-teachers/visas-for-non-uk-trainees"> apply for your visa to train to teach in England</a>.</p>
Expand Down
15 changes: 15 additions & 0 deletions spec/components/find/courses/international_students_component/view_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,21 @@
end
end

context 'when the course has a visa_type of student_visa and sponsorship_availability of :not_available' do
before do
course = build(
:course,
funding: 'fee',
can_sponsor_skilled_worker_visa: false
)
render_inline(described_class.new(course: CourseDecorator.new(course)))
end

it 'does not show the content if visa cannont be sponsored' do
expect(page).to have_no_text('If you do not already have the right to work in the UK, you may need to')
end
end

context 'when the course is salaried and does not sponsor Skilled Worker visas' do
before do
course = build(
Expand Down
Loading