Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend content in Visas cannot be sponsored dropdown #4807

Merged

Conversation

gms-gs
Copy link
Contributor

@gms-gs gms-gs commented Jan 9, 2025

Context

Ticket: https://trello.com/c/lEhhEYZL/281-amend-content-in-visas-cannot-be-sponsored-dropdown

Feedback from GiT is that we shouldn’t link to the ‘Apply for your visa’ GiT page from the ‘Visas cannot be sponsored’ dropdown on Find courses pages.

This is because the ‘Apply for your visa’ page is about courses that offer visa sponsorship. The content on this page is not applicable to courses that do not offer visa sponsorship.

While we’re at it, I would also like to make a couple of minor changes to the ‘Student visas can be sponsored’ and ‘Skilled worker visas can be sponsored’ dropdowns.

Changes proposed in this pull request

  • Update link text from as an international student" to a non-UK citizen
  • Alter conditional logic to remove content if visa_type is student_visa and if sponsorship_availability is available

Guidance to review

  • Visit https://find-review-4807.test.teacherservices.cloud/
  • Go through the flow
  • At the Visa sponsorship section select no
  • View a course and view the sponsorship section, this should match the design
  • Go back to the Visa sponsorship section and select yes
  • View a course and view the sponsorship section, this should match the design

@gms-gs gms-gs added the deploy A Review App will be created for PRs with this label label Jan 9, 2025
@gms-gs gms-gs force-pushed the gs/281-amend-content-in-visas-cannot-be-sponsored-dropdown branch 2 times, most recently from ef6f397 to 47b7db8 Compare January 9, 2025 15:52
@gms-gs gms-gs marked this pull request as ready for review January 9, 2025 16:08
@gms-gs gms-gs requested a review from a team as a code owner January 9, 2025 16:08
@gms-gs gms-gs force-pushed the gs/281-amend-content-in-visas-cannot-be-sponsored-dropdown branch from 47b7db8 to 29103d5 Compare January 10, 2025 10:53
@gms-gs gms-gs force-pushed the gs/281-amend-content-in-visas-cannot-be-sponsored-dropdown branch from 29103d5 to 3d3f9b3 Compare January 10, 2025 10:54
@gms-gs gms-gs self-assigned this Jan 10, 2025
@gms-gs gms-gs requested a review from tomas-stefano January 13, 2025 08:59
@gms-gs gms-gs force-pushed the gs/281-amend-content-in-visas-cannot-be-sponsored-dropdown branch from 23a34e2 to a56a732 Compare January 13, 2025 09:07
@gms-gs gms-gs merged commit 126d4ad into main Jan 13, 2025
19 checks passed
@gms-gs gms-gs deleted the gs/281-amend-content-in-visas-cannot-be-sponsored-dropdown branch January 13, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants