Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove content from the course results and course summary #4696

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

gms-gs
Copy link
Contributor

@gms-gs gms-gs commented Nov 18, 2024

Context

Ticket: https://trello.com/c/qesCyBOR/54-improve-results-1-7-remove-content-from-the-course-results-and-course-summary

The course information on the search results and the course summary on the course page includes information that candidates don’t need in order to compared and narrow down courses.

See live site screenshot - search results

See live site screenshot - course summary

Figma designs: https://lucid.app/lucidspark/971f26f4-cc5e-4993-8f70-efc85b3f0772/edit?invitationId=inv_f64ad81b-8b03-472c-898d-e6c398214ede&page=0_0#

Changes proposed in this pull request

To remove and reorder the content based off the designs

Guidance to review

Expected new UI
Screenshot 2024-11-18 at 16 11 30

Screenshot 2024-11-19 at 15 03 39 Screenshot 2024-11-19 at 15 03 29

@gms-gs gms-gs added the deploy A Review App will be created for PRs with this label label Nov 18, 2024
@gms-gs gms-gs changed the title Improve results - 1/7 - Remove content from the course results and co… Remove content from the course results and course summary Nov 18, 2024
@gms-gs gms-gs self-assigned this Nov 18, 2024
@gms-gs gms-gs force-pushed the gs/update-course-fee branch 3 times, most recently from d6653e1 to 5e21504 Compare November 18, 2024 16:31
@gms-gs gms-gs force-pushed the gs/update-course-fee branch from 5e21504 to 3f2a90d Compare November 18, 2024 16:38
@gms-gs gms-gs force-pushed the gs/update-course-fee branch from 3f2a90d to 3d67bb0 Compare November 18, 2024 16:38
@gms-gs gms-gs marked this pull request as ready for review November 18, 2024 17:04
@gms-gs gms-gs requested a review from a team as a code owner November 18, 2024 17:04
@kelliedesigner
Copy link

Missing a <br> when non-UK citizen fee is present for the hint text to be on a new line:
Screenshot 2024-11-19 at 11 45 41

@kelliedesigner
Copy link

Remove two full stops from salary value and hint text:
Screenshot 2024-11-19 at 11 49 13

@kelliedesigner
Copy link

kelliedesigner commented Nov 19, 2024

Remove full stop after 'apprenticeship' and' There is no fee'
Screenshot 2024-11-19 at 14 53 52

@kelliedesigner
Copy link

Please change 'student finance' to student loans'.

@gms-gs gms-gs force-pushed the gs/update-course-fee branch from 28ccbd7 to 03785fa Compare November 19, 2024 18:46
@gms-gs gms-gs merged commit 5c0d5ec into main Nov 19, 2024
19 checks passed
@gms-gs gms-gs deleted the gs/update-course-fee branch November 19, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants