Update course_results_spec test

DFE-Digital · Nov 18, 2024 · 5e21504 · 5e21504
1 parent fc54cd3
commit 5e21504
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 22 deletions.
diff --git a/app/components/find/courses/summary_component/view.html.erb b/app/components/find/courses/summary_component/view.html.erb
@@ -9,12 +9,12 @@
       <% if course.salaried? %>
         This course pays a <strong>salary</strong>.
         <% if course.apprenticeship? %>
-          It is a Teaching Apprenticeship.
+          It is a teaching apprenticeship.
         <% end %>
         <br>
         <span class="govuk-hint govuk-!-font-size-16">There is no fee.</span>
       <% elsif course.apprenticeship? %>
-        This is a Teaching Apprenticeship course that pays a <strong>salary</strong>.
+        This is a teaching apprenticeship course that pays a <strong>salary</strong>.
         <span class="govuk-hint govuk-!-font-size-16">There is no fee.</span>
       <% else %>
         <%= course.course_fee_content %>

diff --git a/app/components/find/results/search_result_component.html.erb b/app/components/find/results/search_result_component.html.erb
@@ -22,12 +22,12 @@
           <% if course.salaried? %>
             This course pays a <strong>salary</strong>.
             <% if course.apprenticeship? %>
-              It is a Teaching Apprenticeship.
+              It is a teaching apprenticeship.
             <% end %>
             <br>
             <span class="govuk-hint govuk-!-font-size-16">There is no fee.</span>
           <% elsif course.apprenticeship? %>
-            This is a Teaching Apprenticeship course that pays a <strong>salary</strong>.
+            This is a teaching apprenticeship course that pays a <strong>salary</strong>.
             <span class="govuk-hint govuk-!-font-size-16">There is no fee.</span>
           <% else %>
             <%= course.course_fee_content %>

diff --git a/spec/components/find/courses/sumary_component/view_spec.rb b/spec/components/find/courses/sumary_component/view_spec.rb
@@ -12,7 +12,6 @@ module SummaryComponent
 
           result = render_inline(described_class.new(course))
           expect(result.text).to include(
-            'Fee or salary',
             'Course fee',
             'Course length',
             'Age range',
@@ -29,7 +28,9 @@ module SummaryComponent
 
             result = render_inline(described_class.new(course))
             expect(result.text).not_to include('£9,250')
-            expect(result.text).not_to include('Course fee')
+            expect(result.text).to include('Course fee')
+            expect(result.text).to include("This course pays a salary.")
+            expect(result.text).to include("It is a teaching apprenticeship.")
           end
         end
 
@@ -185,7 +186,7 @@ module SummaryComponent
 
             expect(result.text).not_to include('for UK citizens')
             expect(result.text).not_to include('£14,000 for Non-UK citizens')
-            expect(result.text).not_to include('Course fee')
+            expect(result.text).to include('Course fee')
           end
         end
       end

diff --git a/spec/components/find/results/search_result_component_spec.rb b/spec/components/find/results/search_result_component_spec.rb
@@ -92,18 +92,6 @@ module Find
       end
     end
 
-    context 'when there is an accrediting provider' do
-      it 'renders correct message' do
-        course = build(
-          :course,
-          accrediting_provider: build(:provider, :accredited_provider, provider_name: 'ACME SCITT A1')
-        )
-        result = render_inline(described_class.new(course:, results_view:))
-
-        expect(result.text).to include('QTS ratified by ACME SCITT A1')
-      end
-    end
-
     context 'when there is no accrediting provider' do
       it 'renders correct message' do
         course = build(
@@ -122,7 +110,7 @@ module Find
 
         result = render_inline(described_class.new(course:, results_view:))
         expect(result.text).not_to include('£9,250')
-        expect(result.text).not_to include('Course fee')
+        expect(result.text).to include('Course fee')
       end
     end
 
@@ -175,7 +163,7 @@ module Find
 
         expect(result.text).not_to include('for UK citizens')
         expect(result.text).not_to include('£14,000 for Non-UK citizens')
-        expect(result.text).not_to include('Course fee')
+        expect(result.text).to include('Course fee')
       end
     end
 

diff --git a/spec/features/find/search/course_results_spec.rb b/spec/features/find/search/course_results_spec.rb
@@ -46,7 +46,7 @@ def i_see_the_courses
       expect(first_course.provider_name.text).to be_present
       expect(first_course).to have_text('QTS with PGCE')
       expect(first_course).to have_text('1 year - full time')
-      expect(first_course).to have_text('Teaching apprenticeship - with salary')
+      expect(first_course).to have_text('This course pays a salary')
     end
   end