Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bump good_job from 3.29.3 to 4.0.1" #838

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Revert "Bump good_job from 3.29.3 to 4.0.1" #838

merged 1 commit into from
Jul 11, 2024

Conversation

Nitemaeric
Copy link
Contributor

@Nitemaeric Nitemaeric commented Jul 11, 2024 •
edited
Loading

Context

Good Job jobs are failing due to queued jobs not being ready for v4.

Production returns false when GoodJob.v4_ready? is called.

GoodJob.v4_ready? # => false

Changes proposed in this pull request

Guidance

@Nitemaeric Nitemaeric requested a review from a team July 11, 2024 09:43
@Nitemaeric Nitemaeric self-assigned this Jul 11, 2024
@Nitemaeric Nitemaeric requested a review from a team July 11, 2024 09:47
@Nitemaeric Nitemaeric merged commit 23ddeb3 into main Jul 11, 2024
8 checks passed
@Nitemaeric Nitemaeric deleted the revert-bumping-good-job branch July 11, 2024 09:48
@ollietreend ollietreend mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatalinVoineag CatalinVoineag CatalinVoineag approved these changes

Assignees

@Nitemaeric Nitemaeric

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nitemaeric @CatalinVoineag