Prepare the database for Good Job v4 #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to perform some database migrations to prepare for the upgrade from Good Job v3 to v4. I've followed the instructions in [the upgrade guide][1], and have confirmed that the database is now ready by running the following in a Rails console: ``` GoodJob.v4_ready? ``` [1]: https://github.com/bensheldon/good_job?tab=readme-ov-file#upgrading-v3-to-v4
RuboCop complained about the code style of the auto-generated database migrations. Most of these issues were autocorrected by RuboCop. Two were resolved manually.
It wanted me to wrap the `change_table` call in a `safety_assured` block.
|
Note: GoodJob.v4_ready?is a bit sneaky. If there are no enqueued jobs, it will always return |
🤦🏻♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need to perform some database migrations to prepare for the upgrade from Good Job v3 to v4. This will allow us to re-apply the upgrade in #828, which was reverted by #838.
Note
This PR does not upgrade Good Job to v4. It prepares the database for v4, but these changes are still compatible with v3.99.1 which is currently in use.
Changes proposed in this pull request
I've followed the instructions in the upgrade guide. The database migrations were automatically generated by the gem.
I've also updated the DfE Analytics blocklist to exclude the newly added fields.
Guidance to review
Run the migrations in this pull request, then open a Rails console and run:
It should return
true.Link to Trello card
https://trello.com/c/vneRTcpO/554-review-and-merge-dependabot-prs