Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds optional param to TeachingEventAddAttendee #1330

Merged
merged 2 commits into from
Jan 4, 2024
+13 −1
Merged

Adds optional param to TeachingEventAddAttendee #1330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
197a302
Adds optional param to TeachingEventAddAttendee
ekumachidi Dec 15, 2023
ff2a521
Adds Unit test
ekumachidi Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion GetIntoTeachingApi/Models/GetIntoTeaching/TeachingEventAddAttendee.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ public class TeachingEventAddAttendee

[SwaggerSchema(WriteOnly = true)]
public Guid? EventId { get; set; }

[SwaggerSchema(WriteOnly = true)]
public int? ChannelId { get; set; }

[SwaggerSchema(WriteOnly = true)]
public Guid? AcceptedPolicyId { get; set; }
public Guid? PreferredTeachingSubjectId { get; set; }
Expand Down Expand Up @@ -136,7 +140,7 @@ private void ConfigureChannel(Candidate candidate)
{
if (CandidateId == null)
{
candidate.ChannelId = (int?)Candidate.Channel.Event;
candidate.ChannelId = ChannelId ?? (int?)Candidate.Channel.Event;
}
}

Expand Down
8 changes: 8 additions & 0 deletions GetIntoTeachingApiTests/Models/GetIntoTeaching/TeachingEventAddAttendeeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,14 @@ public void Candidate_ChannelIdWhenCandidateIdIsNull_IsMailingList()
request.Candidate.ChannelId.Should().Be((int)Candidate.Channel.Event);
}

[Fact]
public void Candidate_WithNonNullChannelIdWhenCandidateIdIsNull_IsMailingList()
{
var request = new TeachingEventAddAttendee() { CandidateId = null, ChannelId = 456 };

request.Candidate.ChannelId.Should().Be(456);
}

[Fact]
public void Candidate_ChannelIdWhenCandidateIdIsNotNull_IsNotChanged()
{
Expand Down
Loading