Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds optional param to TeachingEventAddAttendee #1330

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

ekumachidi
Copy link
Contributor

@ekumachidi ekumachidi commented Dec 15, 2023

Teams need to be able to attribute event sign-ups in the same way that they do for mailing list and adviser with a query parameter in the format ?channel={channel_id}

  • Adds ChannelId to the TeachingEventAddAttendee model

- Adds `Channel_id` to the model
@github-actions github-actions bot added the VisualCSharp Visual C # label Dec 15, 2023
@ekumachidi ekumachidi self-assigned this Dec 15, 2023
@ekumachidi
Copy link
Contributor Author

@martyn-w
Copy link
Contributor

martyn-w commented Jan 2, 2024

Is there a test needed for the new model attribute? Maybe in GetIntoTeachingApiTests/Models/GetIntoTeaching/TeachingEventAddAttendeeTests.cs ?

@github-actions github-actions bot added the Test Test scripts and harnesses label Jan 2, 2024
Copy link
Contributor

@martyn-w martyn-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Copy link

sonarqubecloud bot commented Jan 2, 2024

@ekumachidi ekumachidi merged commit 27bccea into master Jan 4, 2024
10 of 11 checks passed
@ekumachidi ekumachidi deleted the ce-investigate-bam-channel-capture-for-events branch January 4, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Test scripts and harnesses VisualCSharp Visual C #
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants