Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix claims being flagged for qa #3252

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Fix claims being flagged for qa #3252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/models/claim.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,10 +282,11 @@ def flaggable_for_qa?
def below_min_qa_threshold?
return false if policy::MIN_QA_THRESHOLD.zero?

claims_approved_so_far = Claim.by_policy(policy).current_academic_year.approved.count
approved_claims = Claim.by_policy(policy).by_academic_year(academic_year).approved
claims_approved_so_far = approved_claims.count
return true if claims_approved_so_far.zero?

(Claim.by_policy(policy).current_academic_year.approved.qa_required.count.to_f / claims_approved_so_far) * 100 <= policy::MIN_QA_THRESHOLD
(approved_claims.qa_required.count.to_f / claims_approved_so_far) * 100 <= policy::MIN_QA_THRESHOLD
end

def qa_completed?
Expand Down