Fix claims being flagged for qa #3252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenfodder
approved these changes
Oct 1, 2024
|
Thanks for jumping on this @rjlynch |
When a new academic year has started, and we are yet to approved any claims from this academic year, all claims from the previous year are flagged for qa when approved. To avoid this we need to count the number of approved claims in the _claim's_ academic year rather than the current academic year.
rjlynch
force-pushed
the
CAPT-1835/all-claims-approved-flagged-for-qa
branch
from
b0ff872 to
2fe90f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new academic year has started, and we are yet to approved any claims from this academic year, all claims from the previous year are flagged for qa when approved. To avoid this we need to count the number of approved claims in the claim's academic year rather than the current academic year.