Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LUPEYALPHA-1012] Admin gender task hint #3165

Merged
merged 3 commits into from
Sep 11, 2024
Merged

[LUPEYALPHA-1012] Admin gender task hint #3165

merged 3 commits into from
Sep 11, 2024

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Sep 9, 2024 •
edited
Loading

Context

Other changes

  • Added ostruct gem to fix deprecation warning
  • Fix back link position on payroll gender admin task page

@asmega asmega force-pushed the admin-gender-task-hint branch from b3e7ce7 to 4934043 Compare September 10, 2024 09:21
@asmega asmega added the deploy Deploy a review app for this PR label Sep 10, 2024
@asmega asmega changed the title Admin gender task hint [LUPEYALPHA-1012] Admin gender task hint Sep 10, 2024
@github-actions GitHub Actions
Copy link

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3165-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3165-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3165-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3165-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3165-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3165-web.test.teacherservices.cloud/admin

@asmega asmega marked this pull request as ready for review September 10, 2024 09:42
rjlynch
rjlynch approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Gemfile
@@ -87,6 +87,8 @@ gem "activerecord-copy", require: false
gem "pagy"
gem "rubyzip", require: "zip"

gem "ostruct"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmega asmega force-pushed the admin-gender-task-hint branch from c6c3867 to 2a5f9ba Compare September 11, 2024 10:10
@asmega asmega merged commit 3199a9a into master Sep 11, 2024
14 checks passed
@asmega asmega deleted the admin-gender-task-hint branch September 11, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

Assignees
No one assigned
Labels
deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmega @rjlynch