Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up return reqs. linked to void return logs #1030

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Clean up return reqs. linked to void return logs #1030

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a6f0e4
Clean up return reqs. linked to void return logs
Cruikshanks Oct 14, 2024
a8f3a49
Add void returns to clean queries
Cruikshanks Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions src/modules/return-versions/lib/clean-queries.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,25 @@ const cleanPoints = `
rl.return_requirement = rr.legacy_id::varchar
LIMIT 1
)
UNION ALL
SELECT
rr.return_requirement_id
FROM
water.return_requirements rr
WHERE
NOT EXISTS (
SELECT 1
FROM nald_return_requirements nrr
WHERE rr.external_id = nrr.nald_id
)
AND EXISTS (
SELECT 1
FROM "returns"."returns" rl
WHERE
rl.return_requirement = rr.legacy_id::varchar
AND rl.status = 'void'
LIMIT 1
)
);
`

Expand All @@ -49,6 +68,25 @@ const cleanPurposes = `
rl.return_requirement = rr.legacy_id::varchar
LIMIT 1
)
UNION ALL
SELECT
rr.return_requirement_id
FROM
water.return_requirements rr
WHERE
NOT EXISTS (
SELECT 1
FROM nald_return_requirements nrr
WHERE rr.external_id = nrr.nald_id
)
AND EXISTS (
SELECT 1
FROM "returns"."returns" rl
WHERE
rl.return_requirement = rr.legacy_id::varchar
AND rl.status = 'void'
LIMIT 1
)
);
`

Expand All @@ -75,6 +113,25 @@ const cleanRequirements = `
rl.return_requirement = rr.legacy_id::varchar
LIMIT 1
)
UNION ALL
SELECT
rr.return_requirement_id
FROM
water.return_requirements rr
WHERE
NOT EXISTS (
SELECT 1
FROM nald_return_requirements nrr
WHERE rr.external_id = nrr.nald_id
)
AND EXISTS (
SELECT 1
FROM "returns"."returns" rl
WHERE
rl.return_requirement = rr.legacy_id::varchar
AND rl.status = 'void'
LIMIT 1
)
);
`

Expand Down
Loading