Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up return reqs. linked to void return logs #1030

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Clean up return reqs. linked to void return logs #1030

merged 2 commits into from
Oct 15, 2024

Commits on Oct 14, 2024

  1. Clean up return reqs. linked to void return logs 

    https://eaflood.atlassian.net/browse/WATER-4657

> Part of the work to migrate management of return requirements from NALD to WRLS

Having made return versions and requirements visible to our internal users they have spotted that there are return requirements displayed in WRLS that don't exist.

We know why this is: NALD allows users to delete records. This means a user can create a record in NALD on day 1; we'll see and import the record that night. They can then delete the record (in most cases, it is because a mistake was spotted) on day 2. The import never deletes records, so the errant return requirement remains.

With us taking over management of return requirements, though, it has become important to try to get the 2 systems in sync as much as possible before the import is switched off.

This change builds on the work done in [Add return requirements clean up step to import](#1017). It added the job and the script to remove return requirements that no longer exists in NALD and were not linked to any return logs.

Now we're adding a query to delete any return requirements that no longer exist in NALD and are only linked to `void` return logs.
    @Cruikshanks
    Cruikshanks committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    9a6f0e4 View commit details
    Browse the repository at this point in the history

  2. Add void returns to clean queries

    @Cruikshanks
    Cruikshanks committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a8f3a49 View commit details
    Browse the repository at this point in the history