Removed empty field validation check for postcode #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
teddmason
approved these changes
Sep 26, 2024
teddmason
added a commit
that referenced
this pull request
Oct 10, 2024
* commenting out previous Odour journey work * renaming old smell route tests * returning smell home page for login functionality * SIR-933 * updating some code * fixing tests * Wording changes * SIR-937 - What's your address (#157) * What's your address£ * SIR-934 - location-option (#158) * location-option * linting * removing old code * removing old code files * location-description (#159) * smell/previous (#160) * location-map for smell journey and refactor of water-pollution/location-map * excluding old-smell directories from tests and quality checks * reduced duplication in odour views * SIR-931 : Story – Odour – Remit - What type of activity is the smell coming from? (#170) * Technical implementation for SIR-931 * Updated files to add back link * Fixed sonar issues * Fixed sonar issues * Added new test case files * SIR-939: adding smell/start-date-time (#165) * adding smell/start-date-time * sonarcloud stuff * current page (#167) * smell-strength (#168) * SIR-944 indoors (#169) * SIR-944 indoors * sonarcloud * SIR-1021 easting and northing for odour journey * SIR-938 text update * sorting out duplicates for sonarcloud * SIR-932 : Story – Odour – Remit - Can you give details about the source of the smell? (#175) * Technical implementation for SIR-932 * fixing flakey date test * Fixed sonar issue * Fixed lint issue * Fixed sonar issue --------- Co-authored-by: Tedd Mason <[email protected]> * SIR-949 - contact (#177) * SIR-950 images-or-video (#178) * Odour question and answer IDs * SIR-948 other information (#180) * SIR-987: updating privacy notice for Odour journey (#183) * Technical implementation for SIR-945 (#184) * Removed empty field validation check for postcode (#185) * Removed empty field validation check for postcode * Fixed test case issues * Fixed test case issues * SIR-946 : Story - Odour - Did you have to do any of the following because of the smell? (#188) * Technical implementation for SIR-946 * Updated unit tests to cover more scenarios * Technical implementation for SIR-947 * Revert "Technical implementation for SIR-947" This reverts commit 7ce6606. * Technical implementation for SIR-947 (#189) * removing old-smell code * amending sonar rules * removing old-smell code (#190) * removing old-smell code * amending sonar rules * updating question and answer IDs for sprint * updating question and answer ids and updating other-information unit tests * fixing 5 digit IDs * Adding RPSM prefix for Odour access codes (#191) * Update input label font class to govuk-label (#193) --------- Co-authored-by: sujithvg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.