Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3782 - Add doc lint github action #136

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/operational_task_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ assignees: ''
- Network scope: Select those that apply, or select All
- [ ] All
- [ ] Mainnet
- [ ] Testnet - Goerli
- [ ] Testnet - Sepolia
- [ ] Devnet

Expand Down
36 changes: 32 additions & 4 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,35 @@
## Description
<!-- Provide a brief description of the changes in this PR -->

## Related Issue

This PR implements issue(s) #
diana-borbe-consensys marked this conversation as resolved.
Show resolved Hide resolved
<!-- If this PR addresses an existing issue, please link to it here -->
<!-- e.g., Fixes #123 -->

## Type of Change
<!-- Mark the appropriate option with an "x" -->
- [ ] Bug fix (non-breaking change which fixes an issue)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an additional section for hotfix or do you think Bug fix already covers it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can include both in same category. Do you prefer to keep them separate ?

- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update

## How Has This Been Tested?
<!-- Describe the tests you ran to verify your changes -->
<!-- Include details of your testing environment, and the tests you ran -->

## Checklist:
<!-- Mark completed items with an "x" -->

### Checklist
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have informed the team of any breaking changes if there are any
- [ ] My changes generate no new warnings
- [ ] I wrote new tests for my new core changes
- [ ] I have successfully ran tests, style checker and build against my new changes locally
- [ ] Any dependent changes have been merged and published in downstream modules

* [ ] I wrote new tests for my new core changes.
* [ ] I have successfully ran tests, style checker and build against my new changes locally.
* [ ] I have informed the team of any breaking changes if there are any.
## Additional Notes
<!-- Add any other information about the PR here -->
46 changes: 46 additions & 0 deletions .github/workflows/doc-lint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@

name: Documentation - Check for lint/build errors

on:
pull_request:
paths:
- "**/*.md"
branches:
- main

jobs:
# This job is commented out because of the missing package-lock.json file
# lint:
# name: Lint Code Base, Spelling
# runs-on: [self-hosted, ubuntu-22.04, X64, small]
# timeout-minutes: 10
# permissions:
# contents: read
# env:
# NODE_VERSION: v20.9.0
# steps:
# - uses: actions/checkout@v4
# - name: Create .nvmrc file
# run: |
# echo "${{ env.NODE_VERSION }}" > .nvmrc
# - name: Lint
# uses: Consensys/docs-gha/lint@main
# with:
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

linkCheck:
name: Link Checking
runs-on: [self-hosted, ubuntu-22.04, X64, small]
diana-borbe-consensys marked this conversation as resolved.
Show resolved Hide resolved
timeout-minutes: 10
permissions:
contents: read
strategy:
matrix:
file-extensions: [".md"]
steps:
- uses: actions/checkout@v4
- name: LinkCheck
uses: Consensys/docs-gha/linkcheck@main
with:
FILE_EXTENSION: '${{ matrix.file-extensions }}'
CONFIG_FILE: 'doc_config.json'
25 changes: 25 additions & 0 deletions doc_config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"ignorePatterns": [
{
"pattern": "https://github.com/"
},
{
"pattern": "https://twitter.com/"
},
{
"pattern": "https://support.metamask.io/"
},
{
"pattern": "https://infura.io/faucet/linea"
},
{
"pattern": "https://www.infura.io/faucet/linea"
},
{
"pattern": "https://infura.io"
},
{
"pattern": "https://rpc.sepolia.linea.build"
}
]
}
Loading