Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3782 - Add doc lint github action #136

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

3782 - Add doc lint github action #136

wants to merge 7 commits into from

Conversation

diana-borbe-consensys
Copy link
Collaborator

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/workflows/doc-lint.yaml Show resolved Hide resolved
## Type of Change
<!-- Mark the appropriate option with an "x" -->
- [ ] Bug fix (non-breaking change which fixes an issue)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an additional section for hotfix or do you think Bug fix already covers it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can include both in same category. Do you prefer to keep them separate ?

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.36%. Comparing base (8df8593) to head (dd62af3).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #136   +/-   ##
=========================================
  Coverage     70.36%   70.36%           
  Complexity     1040     1040           
=========================================
  Files           282      282           
  Lines         11316    11316           
  Branches       1083     1083           
=========================================
  Hits           7963     7963           
  Misses         2886     2886           
  Partials        467      467           
Flag Coverage Δ
hardhat 98.70% <ø> (ø)
kotlin 67.84% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants