Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pirates update (see changelog) #476

Merged
merged 101 commits into from
Sep 12, 2024
Merged

Pirates update (see changelog) #476

merged 101 commits into from
Sep 12, 2024

Conversation

danielmartin0
Copy link
Contributor

@danielmartin0 danielmartin0 commented Sep 12, 2024 •
edited
Loading

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Tested Changes:

  1. Have you lint your code (lua lint) locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?

danielmartin0 added 30 commits September 7, 2024 17:37
welcome modal
26ba547
move corpses button to bottom
c689b39
Welcome message in chat also
61220db
old item retrieval system
ecb9d96
more name tweaking
a5e1956
5 crews max
cf21c7b
fix bug with crew not disbanding after loss
8f1bd0e
linter cleanups
c4afbd6
more lint fixes
4ab447a
rename protected_run_cap
986ca08
slightly prettify lobby
44def18
tweak visuals
b99afc3
no marooning
5125bd1
debug on
1880a71
fix starting runs 4/5
3518bad
fix boats ordering
d553a73
omg that bug
57291b7
wait for other crews to load
0282d47
autojoin comment
8f6fba6
fix refunding items when player inv is full
75f5a3d
condense tips section
336e41c
remove endorsements and fix another sloop count bug
1065d69
comment
5096110
less damage at night
6a58e31
scale mining productivity over leagues
6a0316d
comment out memory nils
aab12e2
make cabin into super restricted area
85fe2e4
fix calling Public rather than Balance
0b5ce40
fix game_lost and game_won
e9b988a
stop from opening chests in restricted areas
daa1e82
@danielmartin0 danielmartin0 marked this pull request as ready for review September 12, 2024 12:18
@danielmartin0 danielmartin0 marked this pull request as draft September 12, 2024 12:18
@danielmartin0 danielmartin0 marked this pull request as ready for review September 12, 2024 12:44
@Gerkiz Gerkiz merged commit 63badb6 into ComfyFactory:develop Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmartin0 @Gerkiz