Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing multivariant playlist tags and attributes from draft 15 #132

Merged

Conversation

theRealRobG
Copy link
Collaborator

@theRealRobG theRealRobG commented Sep 3, 2024

Description

This PR brings section 4.4.6 Multivariant Playlist Tags up to date with draft 15 of the specification.

This means a few new tags are added, and there are a lot of updated attributes too, so the various validators have been updated to reflect this.

I intend to bring sections 4.4.2, 4.4.3, 4.4.4, and 4.4.5 up to date in separate PRs.

Change Notes

Pre-submission Checklist

  • I ran the unit tests locally before checking in.
  • I made sure there were no compiler warnings before checking in.
  • I have written useful documentation for all public code.
  • I have written unit tests for this new feature.

@theRealRobG theRealRobG self-assigned this Sep 3, 2024
rmigneco
rmigneco previously approved these changes Sep 9, 2024
Copy link
Collaborator

@rmigneco rmigneco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing comments

@theRealRobG theRealRobG merged commit 9fbb538 into develop_1.x Sep 9, 2024
4 checks passed
@theRealRobG theRealRobG deleted the missing-multivariant-playlist-tags-from-draft-15 branch September 9, 2024 21:47
@theRealRobG theRealRobG mentioned this pull request Oct 4, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants