-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing multivariant playlist tags and attributes from draft 15 #132
Merged
theRealRobG
merged 19 commits into
develop_1.x
from
missing-multivariant-playlist-tags-from-draft-15
Sep 9, 2024
Merged
Add missing multivariant playlist tags and attributes from draft 15 #132
theRealRobG
merged 19 commits into
develop_1.x
from
missing-multivariant-playlist-tags-from-draft-15
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theRealRobG
commented
Sep 3, 2024
...os-Generic HLS Playlist Parsing/Pantos-Generic Tag Validators/HLSPlaylistValidatorImpl.swift
Outdated
Show resolved
Hide resolved
Merged
4 tasks
rmigneco
requested changes
Sep 5, 2024
...HLS Playlist Parsing/Pantos-Generic Tag Validators/EXT_X_SESSION_DATAPlaylistValidator.swift
Outdated
Show resolved
Hide resolved
...HLS Playlist Parsing/Pantos-Generic Tag Validators/EXT_X_SESSION_DATAPlaylistValidator.swift
Outdated
Show resolved
Hide resolved
...-Generic HLS Playlist Parsing/Pantos-Generic Tag Validators/EXT_X_SESSION_KEYValidator.swift
Outdated
Show resolved
Hide resolved
rmigneco
reviewed
Sep 9, 2024
rmigneco
previously approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing comments
rmigneco
approved these changes
Sep 9, 2024
theRealRobG
deleted the
missing-multivariant-playlist-tags-from-draft-15
branch
September 9, 2024 21:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings section 4.4.6 Multivariant Playlist Tags up to date with draft 15 of the specification.
This means a few new tags are added, and there are a lot of updated attributes too, so the various validators have been updated to reflect this.
I intend to bring sections 4.4.2, 4.4.3, 4.4.4, and 4.4.5 up to date in separate PRs.
Change Notes
STABLE-RENDITION-ID
BIT-DEPTH
SAMPLE-RATE
CHANNELS
AVERAGE-BANDWIDTH
SCORE
SUPPLEMENTAL-CODECS
FRAME-RATE
HDCP-LEVEL
ALLOWED-CPC
VIDEO-RANGE
REQ-VIDEO-LAYOUT
STABLE-VARIANT-ID
PATHWAY-ID
Pre-submission Checklist