Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing multivariant playlist tags and attributes from draft 15 (Targeting version 2.x) #133

Merged
merged 19 commits into from
Sep 10, 2024
Merged

Add missing multivariant playlist tags and attributes from draft 15 (Targeting version 2.x) #133

merged 19 commits into from
Sep 10, 2024

Conversation

theRealRobG
Copy link
Collaborator

Description

This PR cherry-picks the changes from #132 into a branch based out of develop to create a version compatible with version 2 of the library.

Change Notes

Pre-submission Checklist

  • I ran the unit tests locally before checking in.
  • I made sure there were no compiler warnings before checking in.
  • I have written useful documentation for all public code.
  • I have written unit tests for this new feature.

@theRealRobG
Adding multivariant playlist tags defined in draft 15 and still missi…
bc451b4 
…ng here

 Conflicts:
	mamba.xcodeproj/project.pbxproj
	mambaSharedFramework/Pantos-Generic HLS Playlist Parsing/Pantos-Generic Tag Validators/HLSPlaylistValidatorImpl.swift
	mambaSharedFramework/Pantos-Generic Playlist Parsing/Pantos-Generic Tag Validators/EXT_X_SESSION_DATAPlaylistValidator.swift
	mambaSharedFramework/Pantos-Generic Playlist Parsing/Pantos-Generic Tag Validators/EXT_X_SESSION_DATATagValidator.swift
	mambaSharedFramework/Pantos-Generic Playlist Parsing/Pantos-Generic Tag Validators/EXT_X_SESSION_KEYValidator.swift
	mambaSharedFramework/PlaylistValidationIssue.swift
@theRealRobG
Add attributes missing from EXT-X-MEDIA as of draft 15
1b516be 
 Conflicts:
	mambaSharedFramework/Pantos-Generic Playlist Parsing/PantosTag.swift
@theRealRobG
Updated test comment with up-to-date docs for EXT-X-MEDIA
b638a0e
@theRealRobG
Add attributes missing from EXT-X-STREAM-INF as of draft 15
2acf718 
 Conflicts:
	mambaSharedFramework/Pantos-Generic Playlist Parsing/PantosTag.swift
@theRealRobG
Add attributes missing from EXT-X-I-FRAME-STREAM-INF as of draft 15
880729d 
 Conflicts:
	mambaSharedFramework/Pantos-Generic Playlist Parsing/PantosTag.swift
@theRealRobG
Updated encryption method enum with new type
4d7f23d
@theRealRobG
Added parsing for CHANNELS attribute
d50ba53 
 Conflicts:
	mamba.xcodeproj/project.pbxproj
	mambaSharedFramework/Pantos-Generic Playlist Parsing/PantosTag.swift
@theRealRobG
Added parsing for HDCP-LEVEL
b662467 
 Conflicts:
	mambaSharedFramework/Pantos-Generic Playlist Parsing/PantosTag.swift
	mambaSharedFramework/ValueTypes.swift
@theRealRobG
Added parsing for VIDEO-RANGE
f7c2e57 
 Conflicts:
	mambaSharedFramework/Pantos-Generic Playlist Parsing/PantosTag.swift
@theRealRobG
Added parsing for REQ-VIDEO-LAYOUT
f48196c 
 Conflicts:
	mamba.xcodeproj/project.pbxproj
	mambaSharedFramework/Pantos-Generic Playlist Parsing/PantosTag.swift
@theRealRobG
Added parsing for FORMAT in EXT-X-SESSION-DATA
23ded16 
 Conflicts:
	mambaSharedFramework/ValueTypes.swift
@theRealRobG theRealRobG added enhancement mamba2.0 A marker for features/bug fixes for a new version of mamba labels Sep 3, 2024
@theRealRobG theRealRobG self-assigned this Sep 3, 2024
@theRealRobG
Corrected location for EXT-X-SESSION-DATA playlist validation
3ea53bb 
 Conflicts:
	mambaSharedFramework/Pantos-Generic HLS Playlist Parsing/Pantos-Generic Tag Validators/HLSPlaylistValidatorImpl.swift
@theRealRobG
Favor structs over classes
1240a1b 
 Conflicts:
	mambaSharedFramework/Pantos-Generic Playlist Parsing/Pantos-Generic Tag Validators/EXT_X_SESSION_DATATagValidator.swift
	mambaSharedFramework/Pantos-Generic Playlist Parsing/Pantos-Generic Tag Validators/EXT_X_SESSION_KEYValidator.swift
	mambaSharedFramework/Pantos-Generic Playlist Parsing/PantosTag.swift
@theRealRobG
Favor not double declaring the issue variable
692ee64 
 Conflicts:
	mambaSharedFramework/Pantos-Generic Playlist Parsing/Pantos-Generic Tag Validators/EXT_X_SESSION_DATAPlaylistValidator.swift
@theRealRobG
Clarified enum naming and favored more terse function syntax
d064651 
 Conflicts:
	mambaSharedFramework/ValueTypes.swift
@theRealRobG
Favor enums rather than structs holding enums
93dfacf 
 Conflicts:
	mambaSharedFramework/ValueTypes.swift
@theRealRobG
Introduce unrecognized cases to keep parsing forward compatible
2782f2d 
 Conflicts:
	mambaSharedFramework/ValueTypes.swift
	mambaTests/Util Tests/Value Types/ChannelsTests.swift
	mambaTests/Util Tests/Value Types/VideoLayoutTests.swift
@theRealRobG
Explicitly indicate class is final
576c6c8 
 Conflicts:
	mambaSharedFramework/Pantos-Generic Playlist Parsing/Pantos-Generic Tag Validators/EXT_X_SESSION_DATAPlaylistValidator.swift
@theRealRobG
Merge branch 'develop' into missing-multivariant-playlist-tags-from-d…
8539920 
…raft-15-2.x
@theRealRobG theRealRobG merged commit 34e7a7d into develop Sep 10, 2024
4 checks passed
@theRealRobG theRealRobG deleted the missing-multivariant-playlist-tags-from-draft-15-2.x branch September 10, 2024 14:43
@theRealRobG theRealRobG mentioned this pull request Oct 3, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmigneco rmigneco rmigneco approved these changes

Assignees

@theRealRobG theRealRobG

Labels
enhancement mamba2.0 A marker for features/bug fixes for a new version of mamba
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theRealRobG @rmigneco