Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClimateMappedAfrica Default Variables #978

Closed
wants to merge 2 commits into from
Closed

ClimateMappedAfrica Default Variables #978

wants to merge 2 commits into from

Conversation

kelvinkipruto
Copy link
Contributor

@kelvinkipruto kelvinkipruto commented Oct 25, 2024 •
edited
Loading

Description

This PR setups some default environment variables on ClimateMappedAfrica.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kelvinkipruto kelvinkipruto marked this pull request as ready for review October 25, 2024 13:39
@kilemensi
Copy link
Member

Can you may be describe what issue is this PR fixing? For example, I don't think NEXT_PUBLIC_SEO_DISABLED is even supported in the climatemappedafrica app.

@kelvinkipruto
Copy link
Contributor Author

@kilemensi We mainly needed NEXT_PUBLIC_IMAGE_UNOPTIMIZED because NextJs optimised images which caused the logo not to appear.

@kilemensi
Copy link
Member

Isn't that same issue fixed in #977 @kelvinkipruto ?

@kelvinkipruto
Copy link
Contributor Author

@kilemensi Yes, it can fix it. I hadn't looked at your PR before working on this.

@koechkevin koechkevin mentioned this pull request Oct 25, 2024
Merged
9 tasks
@kelvinkipruto
Copy link
Contributor Author

This PR is not needed as the issues will be fixed in #977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koechkevin koechkevin koechkevin left review comments

@VinneyJ VinneyJ VinneyJ approved these changes

@kilemensi kilemensi Awaiting requested review from kilemensi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kelvinkipruto @kilemensi @koechkevin @VinneyJ