Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @/climatemappedafrica images on Dev #977

Merged
merged 9 commits into from
Oct 28, 2024

Conversation

kilemensi
Copy link
Member

Description

Main fix is adding a custom loader that will delegate loading of images coming from CMS (/media) to payload directly rather than via Next.js which may fail in weird ways (e.g. Next.js tries to load them via /_next/image?url=). The PR also:

  • Improves the local/S3 image handling: If S3 key and secret are found, S3 is used. Otherwise, local media folder is used
  • Fixes the print icon on explore page
  • Ensure the panel in desktop mode scales well for screens that are lg+ i.e. the rich data/pin icons move accordingly.
  • Ensure TotorialComponentProps exist when there is an tutorial block only.

PS: Lets test the image loading S3/local well to make sure we've fixed it once and for all.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Screenshot 2024-10-25 at 14 55 32

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kilemensi kilemensi requested a review from a team October 25, 2024 12:44
@kilemensi kilemensi self-assigned this Oct 25, 2024
@kilemensi kilemensi added the bug Something isn't working label Oct 25, 2024
Copy link
Contributor

@kelvinkipruto kelvinkipruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koechkevin
Copy link
Contributor

Does this PR close #978 @kelvinkipruto ?

@kilemensi kilemensi added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 90a1ca9 Oct 28, 2024
4 checks passed
@kilemensi kilemensi deleted the fix/climatemappedafrica_fixes branch October 28, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants