Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ft/Featured stories #620

Merged
merged 7 commits into from
Oct 4, 2023
Merged

Ft/Featured stories #620

merged 7 commits into from
Oct 4, 2023

Conversation

kelvinkipruto
Copy link
Contributor

@kelvinkipruto kelvinkipruto commented Oct 3, 2023 •
edited
Loading

Description

This PR implements the Featured stories block

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

image

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kelvinkipruto kelvinkipruto marked this pull request as ready for review October 3, 2023 14:05
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Latest updated Preview URL

Name Review
codeforafrica-ui-pr-620 Visit

kilemensi
kilemensi reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

I think lets call the block NewsAndStories as well (news-stories slug).

apps/codeforafrica/src/payload/blocks/PostsOverView.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/blocks/PostsOverView.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/blocks/PostsOverView.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/blocks/PostsOverView.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/blocks/PostsOverView.js Outdated Show resolved Hide resolved
@kilemensi kilemensi mentioned this pull request Oct 3, 2023
Merged
5 tasks
@kelvinkipruto kelvinkipruto changed the title Ft/posts overview Ft/Featured stories Oct 4, 2023
@kelvinkipruto kelvinkipruto merged commit fbf3c07 into develop Oct 4, 2023
4 checks passed
@kelvinkipruto kelvinkipruto deleted the ft/posts-overview branch October 4, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koechkevin koechkevin koechkevin approved these changes

@kilemensi kilemensi kilemensi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelvinkipruto @kilemensi @koechkevin