Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Featured Projects block #622

Merged
merged 6 commits into from
Oct 4, 2023
Merged

Featured Projects block #622

merged 6 commits into from
Oct 4, 2023

Conversation

koechkevin
Copy link
Contributor

@koechkevin koechkevin commented Oct 3, 2023 •
edited
Loading

Description

Adds our work/projects showcase block to CFA

Fixes issue

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Latest updated Preview URL

Name Review
codeforafrica-ui-pr-622 Visit

kilemensi
kilemensi reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

This is also applicable to #620 @kelvinkipruto

  1. Having looked at the code and functionality, I think we should name these blocks FeaturedXXXX or XXXXSpotlight e.g. FeaturedWork and FeaturedStories vs WorkSpotlight (or OurWorkSpotlight) and ArticlesSpotlight. I think FeaturedXXX naming is better.
  2. Shouldn't we allow content editors to select the projects/stories to feature/spotlight rather than pulling all or x number automatically?

apps/codeforafrica/src/lib/data/blockify/ourWork.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/blocks/OurWorkShowcase.js Outdated Show resolved Hide resolved
@koechkevin koechkevin self-assigned this Oct 4, 2023
@koechkevin koechkevin changed the title Add our work showcase Featured Projects block Oct 4, 2023
@koechkevin koechkevin requested a review from kilemensi October 4, 2023 10:21
kelvinkipruto
kelvinkipruto approved these changes Oct 4, 2023
View reviewed changes
apps/codeforafrica/src/lib/data/blockify/index.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/pages/[...slugs].page.js Outdated Show resolved Hide resolved
kilemensi
kilemensi approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think FeaturedWork is a more inclusive name than FeaturedProject.

apps/codeforafrica/src/lib/data/blockify/featuredProjects.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/lib/data/blockify/featuredProjects.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/lib/data/blockify/featuredProjects.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/blocks/FeaturedProjects.js Outdated Show resolved Hide resolved
@koechkevin koechkevin merged commit 2ed8e77 into develop Oct 4, 2023
@koechkevin koechkevin deleted the feature/projects-showcase branch October 4, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelvinkipruto kelvinkipruto kelvinkipruto approved these changes

@kilemensi kilemensi kilemensi approved these changes

Assignees

@koechkevin koechkevin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koechkevin @kilemensi @kelvinkipruto