Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project List block #610

Merged
merged 27 commits into from
Sep 29, 2023
Merged

Project List block #610

merged 27 commits into from
Sep 29, 2023

Conversation

koechkevin
Copy link
Contributor

Description

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Screenshots

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@koechkevin koechkevin self-assigned this Sep 25, 2023
@koechkevin koechkevin marked this pull request as draft September 25, 2023 12:51
@github-actions
Copy link
Contributor

Latest updated Preview URL

Name Review
codeforafrica-ui-pr-610 Visit

Base automatically changed from feature/cfa-team-members to develop September 26, 2023 06:59
@koechkevin koechkevin marked this pull request as ready for review September 26, 2023 08:57
@kilemensi
Copy link
Member

This was our last discussion on Slack @koechkevin:

We can keep the current implementation i.e. separate Donors/Partners collections.
We can combine the two collections but change the collection name to something like Stakeholders. Both donors and partners fields will now link to stakeholders.

Which approach has been taken in this PR?

Copy link
Contributor

@kelvinkipruto kelvinkipruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@koechkevin Add SEO

@koechkevin
Copy link
Contributor Author

This was our last discussion on Slack @koechkevin:

We can keep the current implementation i.e. separate Donors/Partners collections.
We can combine the two collections but change the collection name to something like Stakeholders. Both donors and partners fields will now link to stakeholders.

Which approach has been taken in this PR?
I introduced a separate Donors block.

The first approach @kilemensi

@koechkevin koechkevin mentioned this pull request Sep 26, 2023
5 tasks
@koechkevin koechkevin changed the title Feature/cfa-projects-list Project List block Sep 27, 2023
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽


Pay attention to how information is organised/flows

apps/codeforafrica/src/components/Projects/Projects.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/components/Projects/Projects.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/fields/dateTime.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/collections/Projects.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/collections/Projects.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/collections/Projects.js Outdated Show resolved Hide resolved
@kilemensi
Copy link
Member

Just run this locally @koechkevin, we seem to be using tags but tags are also used by posts. We end up with things like Projects, Initiatives, Stories, Opportunities, etc., instead of something like 👇🏽

Screenshot 2023-09-28 at 15 16 22

I think works should use different tags or should filter tags for existing works only.

@koechkevin
Copy link
Contributor Author

Just run this locally @koechkevin, we seem to be using tags but tags are also used by posts. We end up with things like Projects, Initiatives, Stories, Opportunities, etc., instead of something like 👇🏽

Screenshot 2023-09-28 at 15 16 22 I think works should use different tags or should filter tags for existing works only.

@kilemensi I have updated this to get from existing works only

@kilemensi
Copy link
Member

Anything that causes image/title to flip @koechkevin (PR vs dev)
s

@kilemensi
Copy link
Member

Also @koechkevin :

Title should be rich text
Screenshot 2023-09-29 at 09 13 32

Description text has wrong font size and links should have icons
s

@koechkevin
Copy link
Contributor Author

Anything that causes image/title to flip @koechkevin (PR vs dev) s

@kilemensi what should be the intended outcome?
In the main branch code image comes before content. Perhaps an issue on the dev site?

@kilemensi
Copy link
Member

@kilemensi what should be the intended outcome? In the main branch code image comes before content. Perhaps an issue on the dev site?

Could be @koechkevin, source of truth should be Figma. What does it say?

@koechkevin
Copy link
Contributor Author

@kilemensi

apps/codeforafrica/payload.config.ts Outdated Show resolved Hide resolved
apps/codeforafrica/src/components/Projects/Projects.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/lib/data/blockify/ourWork.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/collections/Projects.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/collections/Projects.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/fields/links/link.js Outdated Show resolved Hide resolved
@koechkevin koechkevin merged commit b14ba68 into develop Sep 29, 2023
@koechkevin koechkevin deleted the feature/cfa-projects-list branch September 29, 2023 14:36
@kelvinkipruto kelvinkipruto mentioned this pull request Oct 9, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants