-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project List block #610
Project List block #610
Conversation
Latest updated Preview URL
|
This was our last discussion on Slack @koechkevin:
Which approach has been taken in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@koechkevin Add SEO
The first approach @kilemensi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
Pay attention to how information is organised/flows
apps/codeforafrica/src/components/ProjectPageHeader/ProjectPageHeader.js
Outdated
Show resolved
Hide resolved
Just run this locally @koechkevin, we seem to be using tags but tags are also used by posts. We end up with things like Projects, Initiatives, Stories, Opportunities, etc., instead of something like 👇🏽 I think works should use different tags or should filter tags for existing works only. |
@kilemensi I have updated this to get from existing works only |
Anything that causes image/title to flip @koechkevin (PR vs dev) |
Also @koechkevin : Description text has wrong font size and links should have icons |
@kilemensi what should be the intended outcome? |
Could be @koechkevin, source of truth should be Figma. What does it say? |
Description
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Screenshots
Checklist: