-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ft/Improve Posts #621
ft/Improve Posts #621
Conversation
Latest updated Preview URL
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
--
- Is this block for Projects or Stories
- If it's related stories, we'd need a way of relating. One way is making sure they share tags. If it's recent, we need to fetch ordered by publication date descending or something.
- How will the content editors add this block in the CMS? We don't have individual pages for projects or stories in the CMS.
@kilemensi @koechkevin This is now ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My quick review on this @kelvinkipruto
We should change website/settings to be:
- Settings
- Site
- Publication
- Users
Site: This is the current Settings global, just a rename i.e. All site-wide settings will be here.
Publication: This settings will cover everything under Publication. For now we can have just have Posts (as a tab) and under that, we can have Recent Stores, show recent stories checkbox and if checked, allow editors to set title for recent stories. Similar for Recent Opportunities.
Users: Remain as is.
Does my comment make sense @kelvinkipruto? |
@kilemensi Yes. Currently updating it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kelvinkipruto are we planning to add migrations since we are changing slug and production data already exists?
@koechkevin I have backed up the JSON data currently in use. We will use it when we merge this. |
Description
This PR implements some improvements on posts
Type of change
Screenshots
Checklist: