Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue.209 #211

Merged
merged 2 commits into from
May 1, 2024
Merged

Issue.209 #211

merged 2 commits into from
May 1, 2024

Conversation

maxatdetroit
Copy link
Member

@maxatdetroit maxatdetroit commented Apr 30, 2024

Fixes #209

Previously, if data-multi-bars wasn't set to "undefined" or "" then the entire progress bar would fail to get built in the DOM (except the container).

This PR:

  • Removes support for multi-progress bar and associated attribute data-multi-bars

Removing support for this feature as the "fix" for a couple reasons:

  1. If we want to support multi-bar styling, then a more HTML-looking API would be via component composition as opposed to passing a JSON configuration for child components. E.g. Imagine a new component <cod-progress-multi-bar> which allows nested <cod-progress-bars>.
  2. I don't believe this feature is in use anywhere currently, so shouldn't be a problem to remove and re-add later when necessary.

@maxatdetroit maxatdetroit requested a review from jedgar1mx April 30, 2024 17:32
@maxatdetroit maxatdetroit self-assigned this Apr 30, 2024
@maxatdetroit maxatdetroit linked an issue Apr 30, 2024 that may be closed by this pull request
@maxatdetroit maxatdetroit mentioned this pull request Apr 30, 2024
@jedgar1mx jedgar1mx merged commit 3878a73 into 2.0.0-alpha1 May 1, 2024
1 check passed
@jedgar1mx jedgar1mx deleted the issue.209 branch May 1, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix progress bar 'undefined' attributes
2 participants