Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progress bar 'undefined' attributes #209

Closed
maxatdetroit opened this issue Apr 30, 2024 · 0 comments · Fixed by #211
Closed

Fix progress bar 'undefined' attributes #209

maxatdetroit opened this issue Apr 30, 2024 · 0 comments · Fixed by #211
Assignees
Labels
bug Something isn't working

Comments

@maxatdetroit
Copy link
Member

maxatdetroit commented Apr 30, 2024

Describe the bug

When cod-progress-bar is used data-multi-bars must be set to undefined instead of omitting those attributes altogether in order for the component to render at all.

To Reproduce

See https://github.com/CityOfDetroit/detroitmi/pull/1405#discussion_r1584978669.

Proposed Solution

Provide sensible defaults for those attributes and don't require they are set to undefined in order for the component to render.

@maxatdetroit maxatdetroit added the bug Something isn't working label Apr 30, 2024
@maxatdetroit maxatdetroit self-assigned this Apr 30, 2024
@maxatdetroit maxatdetroit mentioned this issue Apr 30, 2024
@maxatdetroit maxatdetroit linked a pull request Apr 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant