Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common story arguments #210

Merged
merged 3 commits into from
May 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 112 additions & 0 deletions src/shared/js/storybook/args-utils.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
const COMMON_STORY_ARGS = {
disabled: {
control: { type: 'boolean' },
},
required: {
control: { type: 'boolean' },
},
checked: {
control: { type: 'boolean' },
},
readOnly: {
control: { type: 'boolean' },
},
bootstrapColor: {
control: { type: 'select' },
options: [
'primary',
'secondary',
'success',
'info',
'warning',
'danger',
'light',
'dark',
'accent-primary',
'accent-secondary',
],
},
// TODO: Use bootstrap color names. Issue #202.
numberColor: {
control: { type: 'select' },
options: [
'color-1',
'color-2',
'color-3',
'color-4',
'color-5',
'color-light',
'color-dark',
],
},
order: {
control: { type: 'select' },
options: ['left', 'right'],
},
// TODO: Make the following two size attr names/values
// consistent. Issue #202.
size: {
control: { type: 'select' },
options: ['sm', 'md', 'lg', 'xl'],
},
longSize: {
control: { type: 'select' },
options: ['small', 'medium', 'large', 'x-large'],
},
icon: {
control: { type: 'select' },
options: [
'bicycle',
'bounding-box',
'bounding-box-circle',
'building',
'building-fill',
'buildings',
'buildings-fill',
'bus-front',
'bus-front-fill',
'calendar',
'calendar-fill',
'calendar-date',
'calendar-date-fill',
'cash',
'check-circle',
'check-circle-fill',
'chevron-right',
'chevron-right-circle',
'chevron-right-circle-fill',
'chevron-left',
'chevron-left-circle',
'chevron-left-circle-fill',
'chevron-up',
'chevron-up-circle',
'chevron-up-circle-fill',
'chevron-down',
'chevron-down-circle',
'chevron-down-circle-fill',
'currency-dollar',
'exclamation-circle',
'exclamation-circle-fill',
'exclamation-triangle',
'file-earmark',
'funnel',
'funnel-fill',
'house',
'house-fill',
'list-task',
'newspaper',
'no-parking',
'no-parking-fill',
'journals',
'p-circle',
'p-circle-fill',
'toilet',
'universal-access',
'universal-access-circle',
'wifi',
'wifi-off',
].sort(),
},
};

export { COMMON_STORY_ARGS };
7 changes: 5 additions & 2 deletions src/stories/actionbutton.stories.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
import { html } from 'lit-html';
import '../components/atoms/ActionButton/cod-action-button';
import '../components/atoms/Icon/cod-icon';
import IconStory from './icon.stories';
import { COMMON_STORY_ARGS } from '../shared/js/storybook/args-utils';

export default {
component: 'cod-action-button',
title: 'Components/Atoms/ActionButton',
// 👇 Creates specific argTypes
argTypes: {
// TODO: Make this attr name and accepted
// values consistent with other action button, progress bar,
// etc. Issue #202.
buttonColor: {
options: [
'btn-outline-primary',
Expand All @@ -16,7 +19,7 @@ export default {
],
control: 'select',
},
icon: IconStory.argTypes.icon,
icon: COMMON_STORY_ARGS.icon,
title: {
control: 'text',
},
Expand Down
7 changes: 5 additions & 2 deletions src/stories/actionbuttonV2.stories.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
import { html } from 'lit-html';
import '../components/atoms/ActionButtonV2/cod-action-button-v2';
import '../components/atoms/Icon/cod-icon';
import IconStory from './icon.stories';
import { COMMON_STORY_ARGS } from '../shared/js/storybook/args-utils';

export default {
component: 'cod-action-button-v2',
title: 'Components/Atoms/ActionButtonV2',
// 👇 Creates specific argTypes
argTypes: {
// TODO: Make this attr name and accepted
// values consistent with other action button, progress bar,
// etc. Issue #202.
buttonColor: {
options: [
'btn-outline-primary',
Expand All @@ -16,7 +19,7 @@ export default {
],
control: 'select',
},
icon: IconStory.argTypes.icon,
icon: COMMON_STORY_ARGS.icon,
title: {
control: 'text',
},
Expand Down
38 changes: 5 additions & 33 deletions src/stories/alert.stories.js
Original file line number Diff line number Diff line change
@@ -1,41 +1,13 @@
import '../components/atoms/Alert/cod-alert';
import { COMMON_STORY_ARGS } from '../shared/js/storybook/args-utils';

export default {
title: 'Components/Atoms/Alert',
argTypes: {
icon: {
control: { type: 'select' },
options: [
'house',
'house-fill',
'exclamation-circle',
'exclamation-circle-fill',
'exclamation-triangle',
'check-circle',
'check-circle-fill',
],
},
iconOrder: {
control: { type: 'select' },
options: ['left', 'right'],
},
iconSize: {
control: { type: 'select' },
options: ['small', 'medium', 'large', 'x-large'],
},
backgroundColor: {
control: { type: 'select' },
options: [
'primary',
'secondary',
'success',
'info',
'warning',
'danger',
'light',
'dark',
],
},
icon: COMMON_STORY_ARGS.icon,
iconOrder: COMMON_STORY_ARGS.order,
iconSize: COMMON_STORY_ARGS.longSize,
backgroundColor: COMMON_STORY_ARGS.bootstrapColor,
},
};
// Template
Expand Down
16 changes: 2 additions & 14 deletions src/stories/badge.stories.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { html } from 'lit-html';
import '../components/atoms/Badge/cod-badge';
import { COMMON_STORY_ARGS } from '../shared/js/storybook/args-utils';

export default {
title: 'Components/Atoms/Badge',
Expand All @@ -9,20 +10,7 @@ export default {
options: ['span', 'div', 'a'],
defaultValue: 'span',
},
backgroundColor: {
control: { type: 'select' },
options: [
'primary',
'secondary',
'success',
'info',
'warning',
'danger',
'light',
'dark',
],
defaultValue: 'primary',
},
backgroundColor: COMMON_STORY_ARGS.bootstrapColor,
},
};
// Template
Expand Down
55 changes: 12 additions & 43 deletions src/stories/button.stories.js
Original file line number Diff line number Diff line change
@@ -1,59 +1,28 @@
import '../components/atoms/Button/cod-button';
import '../components/atoms/Icon/cod-icon';
import { COMMON_STORY_ARGS } from '../shared/js/storybook/args-utils';

export default {
title: 'Components/Atoms/Button',
argTypes: {
primary: {
control: { type: 'boolean' },
},
disable: {
control: { type: 'boolean' },
},
backgroundColor: {
control: { type: 'select' },
options: [
'primary',
'secondary',
'success',
'info',
'warning',
'danger',
'light',
'dark',
'accent-primary',
'accent-secondary',
],
},
onClick: { action: 'onClick' },
disable: COMMON_STORY_ARGS.disabled,
// TODO: Make this attr name and accepted
// values consistent with other action button, progress bar,
// etc. Issue #202.
backgroundColor: COMMON_STORY_ARGS.bootstrapColor,
// TODO: Add support for lg and xl to make size
// consistent. Issue #202.
size: {
control: { type: 'select' },
options: ['sm', 'md', 'lg'],
},
icon: {
control: { type: 'select' },
options: [
'house',
'house-fill',
'exclamation-circle',
'exclamation-circle-fill',
'exclamation-triangle',
'check-circle',
'check-circle-fill',
'calendar',
'calendar-fill',
'calendar-date',
'calendar-date-fill',
],
},
iconSize: {
control: { type: 'select' },
options: ['small', 'medium', 'large', 'x-large'],
},
iconOrder: {
control: { type: 'select' },
options: ['left', 'right'],
},
icon: COMMON_STORY_ARGS.icon,
onClick: { action: 'onClick' },
iconSize: COMMON_STORY_ARGS.longSize,
iconOrder: COMMON_STORY_ARGS.order,
shape: {
control: { type: 'select' },
options: ['fluid', 'square'],
Expand Down
15 changes: 3 additions & 12 deletions src/stories/container.stories.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import '../components/atoms/Container/cod-container';
import { COMMON_STORY_ARGS } from '../shared/js/storybook/args-utils';

export default {
title: 'Components/Atoms/Container',
Expand All @@ -15,18 +16,8 @@ export default {
'container-fluid',
],
},
backgroundColor: {
control: { type: 'select' },
options: [
'color-1',
'color-2',
'color-3',
'color-4',
'color-5',
'color-light',
'color-dark',
],
},
// TODO: Use bootstrap color names. Issue #202.
backgroundColor: COMMON_STORY_ARGS.numberColor,
},
};
// Template
Expand Down
15 changes: 2 additions & 13 deletions src/stories/form.stories.js
Original file line number Diff line number Diff line change
@@ -1,21 +1,10 @@
import '../components/organisms/Form/cod-form';
import { COMMON_STORY_ARGS } from '../shared/js/storybook/args-utils';

export default {
title: 'Forms/FormValidation',
argTypes: {
backgroundColor: {
control: { type: 'select' },
options: [
'primary',
'secondary',
'success',
'info',
'warning',
'danger',
'light',
'dark',
],
},
backgroundColor: COMMON_STORY_ARGS.bootstrapColor,
},
};
// Template
Expand Down
Loading
Loading