Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common story arguments #210

Merged
merged 3 commits into from
May 2, 2024
Merged

Use common story arguments #210

merged 3 commits into from
May 2, 2024

Conversation

maxatdetroit
Copy link
Member

@maxatdetroit maxatdetroit commented Apr 30, 2024

Part of #202

This is another refactor to reuse storybook arguments across stories. This will make it easier for us to refactor attributes to give them consistent names and values in #202.

This is a no-op. Storybook should work the same in chromatic.

We'll merge this into dev, then merge dev into 2.0.0-alpha1 to make the uxds 2.0 easier to develop.

@maxatdetroit maxatdetroit requested a review from jedgar1mx April 30, 2024 16:53
@maxatdetroit maxatdetroit self-assigned this Apr 30, 2024
@jedgar1mx
Copy link
Member

It looks like some items don't have the same options to follow specially on the sizes and colors. We might need to add the missing options or just create different parameter option for those cases. For example the spinner size is not working with all the options.

@maxatdetroit
Copy link
Member Author

maxatdetroit commented May 1, 2024

@jedgar1mx the differing size arguments was a bug. Some components don't support lg or xl. I fixed that issue.

The differing color arguments was just some missing configurations. AFAIK all the components that gained color options in this PR support those options. E.g. <cod-spinner data-background-color="accent-secondary"/> works OK. See the demo here: https://is.gd/JN4pid

Should be ready for review & merge.

@maxatdetroit maxatdetroit reopened this May 1, 2024
@jedgar1mx jedgar1mx merged commit 2d7a391 into dev May 2, 2024
8 checks passed
@jedgar1mx jedgar1mx deleted the story.utils branch May 2, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants