Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Release 4.0.0): HDS-2069: Select part 5 #1377

Merged
merged 18 commits into from
Oct 18, 2024
Merged

(Release 4.0.0): HDS-2069: Select part 5 #1377

merged 18 commits into from
Oct 18, 2024

Commits on Oct 10, 2024

  1. (hds-2069) Added global.d.ts to included ts files 

    This is to suppress "not found" errors with some *.module.scss
    @NikoHelle
    NikoHelle committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    367cb40 View commit details
    Browse the repository at this point in the history

  2. (hds-2069) Added and export option selectors 

    Best to keep selectors with the HTML code.

Selectors are needed when resolving where user interactions with mouse/keyboard happened.

Also used to shift focus when navigating with keyboard.
    @NikoHelle
    NikoHelle committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1a07dcf View commit details
    Browse the repository at this point in the history

  3. (hds-2069) Hook for detecting and querying elements 

    Used to find out which kind of element had an event and where to find an element and pick siblings etc for navigation.
    @NikoHelle
    NikoHelle committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b1b7ad4 View commit details
    Browse the repository at this point in the history

  4. (hds-2069) New element refs for element detection

    @NikoHelle
    NikoHelle committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ff6b37a View commit details
    Browse the repository at this point in the history

  5. (hds-2069) Utility functions to get secondary element from blur/focus… 

    … events
    @NikoHelle
    NikoHelle committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    894e7ce View commit details
    Browse the repository at this point in the history

  6. (hds-2069) onFocus, onBlur, active-descendant and focusTarget to data

    @NikoHelle
    NikoHelle committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a723001 View commit details
    Browse the repository at this point in the history

  7. (hds-2069) Hook for handling focus shifting and event 

    Handles:
- when menu is opened focus is moved to first element
- when list loses focus, it is closed
- when a tag is removed focus is moved to first tag / button
- button is focused after many changes

Tracks active-descendant for screen readers

Calls also blur / focus callbacks
    @NikoHelle
    NikoHelle committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    2642fc9 View commit details
    Browse the repository at this point in the history

  8. (hds-2069) Story with onFocus / onBlur

    @NikoHelle
    NikoHelle committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    92f6a63 View commit details
    Browse the repository at this point in the history

  9. (hds-2069) Change playwright config to take pics on failurs 

    Commented out recordVideo-prop or VSCode plugin records videos
    @NikoHelle
    NikoHelle committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4e827d7 View commit details
    Browse the repository at this point in the history

  10. (hds-2069) Rename e2e "helpers" to "playwright" util 

    There will be many more utils, so this is better namings
    @NikoHelle
    NikoHelle committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5dfa177 View commit details
    Browse the repository at this point in the history

  11. (hds-2069) Active-descendant to button

    @NikoHelle
    NikoHelle committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    c771549 View commit details
    Browse the repository at this point in the history

  12. (hds-2069) Select stories to keep options constants 

    If options are random, visual tests fail. Added also ids to find components in PW tests
    @NikoHelle
    NikoHelle committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    461dffb View commit details
    Browse the repository at this point in the history

  13. (hds-2069) Hook for handling keyboard commands

    @NikoHelle
    NikoHelle committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f53db40 View commit details
    Browse the repository at this point in the history

  14. (hds-2069) Use focus/keyboard/ hooks in Container

    @NikoHelle
    NikoHelle committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    21b234a View commit details
    Browse the repository at this point in the history

  15. (hds-2069) Do not show visual Search/Filter info without texts

    @NikoHelle
    NikoHelle committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    cc4e58f View commit details
    Browse the repository at this point in the history

  16. (hds-2069) Select tests to Playwright

    @NikoHelle
    NikoHelle committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f0e545f View commit details
    Browse the repository at this point in the history

  17. (hds-2069) Updated Koros with 1px shift

    @NikoHelle
    NikoHelle committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    971113e View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. (hds-2069) Change focus story colors to hds colors

    @NikoHelle
    NikoHelle committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    637ad17 View commit details
    Browse the repository at this point in the history