(Release 4.0.0): HDS-2069: Select part 5 #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to suppress "not found" errors with some *.module.scss
Best to keep selectors with the HTML code. Selectors are needed when resolving where user interactions with mouse/keyboard happened. Also used to shift focus when navigating with keyboard.
Used to find out which kind of element had an event and where to find an element and pick siblings etc for navigation.
Handles: - when menu is opened focus is moved to first element - when list loses focus, it is closed - when a tag is removed focus is moved to first tag / button - button is focused after many changes Tracks active-descendant for screen readers Calls also blur / focus callbacks
Commented out recordVideo-prop or VSCode plugin records videos
There will be many more utils, so this is better namings
If options are random, visual tests fail. Added also ids to find components in PW tests
NikoHelle
changed the base branch from
development
to
feature/hds-2069-select-v4
Test Results 1 files 20 suites 3m 32s ⏱️ Results for commit 637ad17. ♻️ This comment has been updated with latest results. |
|
Preview found from hds-demo docs/preview_1377 Demos |
laurakarhu
approved these changes
Oct 11, 2024
mrTuomoK
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added keyboard commands, focus shifting and handling, onFocus/onBlur and active-descendant for accessibility.
Added also Playwright-tests and PW utils.
Missing:
Related Issue
Closes HDS-2069
Motivation and Context
How Has This Been Tested?
Unit and Playwright
Demos:
Links to demos are in the comments
Screenshots (if appropriate):
Add to changelog
Changelog added later with last part