Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verify_eigrp_interfaces_timers API to verify.py ios/iosxe eigrp protocol (my previous contribution) supporting EIGRPv4 and EIGRPv6 for IOS/IOSXE #161

Closed
wants to merge 40 commits into from

Conversation

cherifimehdi
Copy link
Contributor

Hello,

I added verify_eigrp_interfaces_timers API to verify.py (my previous contribution) for ios/iosxe eigrp protocol.

I added the tests folder verify_eigrp_interfaces_timers at pkgs/sdk-pkg/src/genie/libs/sdk/apis/tests/iosxe/eigrp/verify

I added the changelog_add_verify_eigrp_interfaces_timers_apis_202419041835 file at pkgs/sdk-pkg/changelog folder

Thank you for reviewing my contribution

add mock for verify_eigrp_interfaces_timers
…verify_eigrp_interfaces_timers/mock_data/iosxe/test
Add test_api_verify_eigrp_interfaces_timers.py
Add verify_eigrp_interfaces_timers APIs for IOSXE/IOS EIGRP verify supporting ipv4 and ipv6 to my previous contribution verify.py
Add changelog_add_verify_eigrp_interfaces_timers_apis_202419041835
@cherifimehdi
Copy link
Contributor Author

Hello @omehrabi @domachad here you find my PR for API pyATS contribution. Thank you

@cherifimehdi
Copy link
Contributor Author

Hi @omehrabi, I would just like to point out that I took into consideration for this PR all your remarks from my previous contribution. Thank you

@cherifimehdi
Copy link
Contributor Author

Hi @omehrabi @domachad @Harishv01 can you please review my PR, I submitted it since 02 weeks.
I think this one can be merged directly since I took all the remarks from my previous PR for pyATS APIs
Thanks

The change according to comments and suggestions
The change to add "show version | include operating mode: ''"
…verify_eigrp_interfaces_timers/mock_data/iosxe/mock_data.yaml
…verify_eigrp_interfaces_timers/mock_data/iosxe/tst
New with suggested modification
…verify_eigrp_interfaces_timers/mock_data/iosxe directory
…verify_eigrp_interfaces_timers/mock_data/iosxe/tst
@cherifimehdi
Copy link
Contributor Author

Hi @omehrabi @domachad I did all change but test failed. Can you please assist me because normally there will be no problem. Thanks

…verify_eigrp_interfaces_timers/mock_data/iosxe/mock_data.yaml

Co-authored-by: Douglas Monteiro <[email protected]>
New verify.py
@cherifimehdi
Copy link
Contributor Author

I tried many times always test failed!

@cherifimehdi
Copy link
Contributor Author

Please @omehrabi @domachad why tests failed?

@cherifimehdi cherifimehdi reopened this May 9, 2024
Copy link
Contributor Author

@cherifimehdi cherifimehdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

Copy link
Contributor Author

@cherifimehdi cherifimehdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

Copy link
Contributor Author

@cherifimehdi cherifimehdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@cherifimehdi
Copy link
Contributor Author

@omehrabi @domachad @SohanTirpude @Harishv01 I think it is better to close this PR since always tests fail when I try to update my PR according to remarks and since there is no answer why from reviewers. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants