-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verify_eigrp_interfaces_timers API to verify.py ios/iosxe eigrp protocol #165
Conversation
add mock for verify_eigrp_interfaces_timers
…verify_eigrp_interfaces_timers/mock_data/iosxe/test
Add test_api_verify_eigrp_interfaces_timers.py
Add verify_eigrp_interfaces_timers APIs for IOSXE/IOS EIGRP verify supporting ipv4 and ipv6 to my previous contribution verify.py
Add changelog_add_verify_eigrp_interfaces_timers_apis_202419041835
The change according to comments and suggestions
The change to add "show version | include operating mode: ''"
…verify_eigrp_interfaces_timers/mock_data/iosxe/mock_data.yaml
…verify_eigrp_interfaces_timers/mock_data/iosxe/tst
New with suggested modification
…verify_eigrp_interfaces_timers/mock_data/iosxe directory
…verify_eigrp_interfaces_timers/mock_data/iosxe/tst
…verify_eigrp_interfaces_timers/mock_data/iosxe/mock_data.yaml Co-authored-by: Douglas Monteiro <[email protected]>
…verify_eigrp_interfaces_timers/mock_data/iosxe/mock_data.yaml Co-authored-by: Douglas Monteiro <[email protected]>
New verify.py
New verify.py
…verify_eigrp_interfaces_timers directory Delete old tests
Add new mock_data.yaml
…verify_eigrp_interfaces_timers/mock_data/iosxe/test
New test_api_verify_eigrp_interfaces_timers.py file
…verify_eigrp_interfaces_timers directory
…verify_eigrp_interfaces_timers/test
…verify_eigrp_interfaces_timers/tst
…verify_eigrp_interfaces_timers/mock_data/iosxe/tst
Hi @Taarini @SohanTirpude @lsheikal broken tests when I synced the fork to update the branch! please what is the problem? |
@Taarini @SohanTirpude @lsheikal any help...suggession...idea? |
Hi @Taarini @SohanTirpude @lsheikal @ThomasJRyan I think there is a problem in pyATS after last update since tests keep fail after modification in PR |
Hello @Taarini @SohanTirpude @lsheikal still no answer and solution? |
Hi @SohanTirpude @Taarini @lsheikal Now test PASSED after I made update for my branch. I think there was a problem in the prvious version! |
1 similar comment
Hi @SohanTirpude @Taarini @lsheikal Now test PASSED after I made update for my branch. I think there was a problem in the prvious version! |
@Taarini approved my PR on May 31, please @lsheikal @SohanTirpude can you approve or review if there is anything else to modify cause it's been almost two months? THANKS |
Co-authored-by: Lukeman Hakkim <[email protected]>
Hi @lsheikal thank you for reviewing my PR. I applied your suggestion |
Hello,
I added verify_eigrp_interfaces_timers API to verify.py (my previous contribution) for ios/iosxe eigrp protocol.
I added the tests folder verify_eigrp_interfaces_timers at pkgs/sdk-pkg/src/genie/libs/sdk/apis/tests/iosxe/eigrp/verify
I added the changelog_add_verify_eigrp_interfaces_timers_apis_202419041835 file at pkgs/sdk-pkg/changelog folder
Thank you for reviewing my contribution