Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update gcp-cli orbs #58

Closed
wants to merge 2 commits into from
Closed

feat: update gcp-cli orbs #58

wants to merge 2 commits into from

Conversation

inobu
Copy link

@inobu inobu commented Oct 6, 2022

SEMVER Update Type:

  • Major
  • Minor
  • Patch

Description:

Updated gcp-cli to the latest version and specified the default version of gcloud that gcp-cli uses

Motivation:

The orb can not be used because the version of python3 is high in the image maintained by circleci.

Closes Issues:

Checklist:

  • All new jobs, commands, executors, parameters have descriptions.
  • Usage Example version numbers have been updated.
  • Changelog has been updated.

@inobu inobu requested a review from a team as a code owner October 6, 2022 10:22
@Jaryt
Copy link
Contributor

Jaryt commented Oct 18, 2022

Hi @inobu, thank you for submitting this PR!

We are currently discussing the probability of removing the gcp cli from the orb as the coupling of versions is problematic. e.g. if we provide more functionality in the gcp cli orb, we'd have to implement all parameters within the gcr orb. This creates a slightly more of an investment in configuring but is beneficial in the long run.

@inobu
Copy link
Author

inobu commented Oct 19, 2022

Hi @Jaryt Thank you for your reply.

I'm sure what you're saying is correct in principle of program design, because software entities (classes, modules, functions, etc.) should be open for extension, but closed for modification.
However, it is also true that orb does not work with the latest cimg/go:1.19.2, so please include this as a temporary solution.

@Jaryt
Copy link
Contributor

Jaryt commented Oct 20, 2022

The decoupling from the cli has begun on #60. Waiting for upgrades on the cli orb to be merged.

@Jaryt Jaryt closed this Oct 20, 2022
@inobu inobu deleted the update-gcp-cli-orb branch October 21, 2022 03:54
@inobu
Copy link
Author

inobu commented Oct 21, 2022

Thank you

@yanns yanns mentioned this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants