Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix policies for networks #4325

Merged
merged 3 commits into from
May 15, 2024
Merged

fix: fix policies for networks #4325

merged 3 commits into from
May 15, 2024

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented May 14, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • moved policy network definitions to Forest,
  • fixed incorrect valid proof types in network policies,
  • bumped the fil_actor_states to use the latest Policy definition (from v13)

Reference issue to close (if applicable)

Closes #4314

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs mentioned this pull request May 14, 2024
Merged
@LesnyRumcajs LesnyRumcajs force-pushed the fix-policy-network branch 2 times, most recently from 8797c00 to a7d8407 Compare May 15, 2024 08:59
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review May 15, 2024 09:01
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner May 15, 2024 09:01
@LesnyRumcajs LesnyRumcajs requested review from ruseinov and lemmih and removed request for a team May 15, 2024 09:01
@ruseinov
Copy link
Contributor

Needs to pass all the tests. Not sure what is going wrong with the RPC tests, perhaps it's just flaky.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue May 15, 2024
@LesnyRumcajs LesnyRumcajs removed this pull request from the merge queue due to a manual request May 15, 2024
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit fcb5f56 May 15, 2024
28 checks passed
@LesnyRumcajs LesnyRumcajs deleted the fix-policy-network branch May 15, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruseinov ruseinov ruseinov approved these changes

@lemmih lemmih lemmih approved these changes

@sudo-shashank sudo-shashank sudo-shashank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify network definitions
4 participants
@LesnyRumcajs @ruseinov @lemmih @sudo-shashank