Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: no network in policies + use v13 as export #295

Merged
merged 1 commit into from
May 15, 2024
Merged

chore: no network in policies + use v13 as export #295

merged 1 commit into from
May 15, 2024

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented May 14, 2024 •
edited
Loading

Summary of changes
Changes introduced in this pull request:

  • ⚠️ this is a breaking change, a major version bump will be required,
  • remove network definitions from the policies - they were incorrect, introduced unnecessary coupling, strived away from the original implementation and were by large re-defined in Forest itself.
  • make v13 policy the default, exported one.

Reference issue to close (if applicable)

Close

Other information and links

Corresponding Forest PR ChainSafe/forest#4325

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner May 14, 2024 15:45
@LesnyRumcajs LesnyRumcajs requested review from ruseinov and lemmih and removed request for a team May 14, 2024 15:45
ruseinov
ruseinov approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@ruseinov ruseinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, it was indeed confusing to see references to networks in fil_actor_states.

@hanabi1224 hanabi1224 mentioned this pull request May 15, 2024
Closed
@sudo-shashank sudo-shashank added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 2cf7156 May 15, 2024
5 checks passed
@sudo-shashank sudo-shashank deleted the no-network-policy branch May 15, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruseinov ruseinov ruseinov approved these changes

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@lemmih lemmih Awaiting requested review from lemmih lemmih is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LesnyRumcajs @ruseinov @hanabi1224 @sudo-shashank