-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up and reorganize ACesiumGeoreference, and improve its transformation API #1179
Conversation
And a passing test.
Thanks for the pull request @kring!
Reviewers, don't forget to make sure that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Minor questions and comments about new and old code.
In addition to looking at the code, I verified blueprints access still looked sensible, and that the new test is running on CI. CesiumGeoreference was probably the hardest to review as the diff was probably the most confused with the .cpp file.
This is a PR into #1174 so merge that first.
Lots of (mostly small) changes to CesiumGeoreference:
glm
functions from CesiumGeoreference. Now that UE's FMatrix and FVector are double-precision, there's little need for these.UCesiumWgs84Ellipsoid
blueprint function library (also usable from C++). This is similar to how Cesium for Unity is organized. Unfortunately it doesn't seem possible to CoreRedirect an instance method to a static one, so deprecated methods still exist on CesiumGeoreference as well.Documentation/developing-uobjects.md
.Fixes #724
Related to #1170 but not a complete fix just yet