Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sw/UI velocity #38

Merged
merged 25 commits into from
Feb 8, 2024
Merged

Sw/UI velocity #38

merged 25 commits into from
Feb 8, 2024

Conversation

TiaSinghania
Copy link
Collaborator

Added another subclass for Controller that launches a tkinter window. Allows user to use up and down arrow keys to increase and decrease the published velocity from 0 to 30 in increments of 0.1.

Copy link

@vluu23 vluu23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

A few questions:

  • How do we use this? Can you update the readme/instructions?
  • Might be a good idea to have the velocities display in the tk window too.
  • Label the tk windows for each individual buggy?
  • Check necessary imports?

rb_ws/src/buggy/scripts/auton/autonsystem.py Outdated Show resolved Hide resolved
rb_ws/src/buggy/scripts/2d_sim/velocity_ui.py Show resolved Hide resolved
rb_ws/src/buggy/scripts/2d_sim/velocity_ui.py Show resolved Hide resolved
rb_ws/src/buggy/scripts/2d_sim/velocity_ui.py Show resolved Hide resolved
@christianvluu
Copy link
Collaborator

Just realized I accidentally used my other git account for the review... whoops (vluu23 is me)

@christianvluu
Copy link
Collaborator

Also please pull in the most recent changes from the main branch (there's CI stuff in there which will help with readability).

@TiaSinghania TiaSinghania requested a review from Jackack February 5, 2024 15:40
@TiaSinghania TiaSinghania requested a review from vluu23 February 5, 2024 15:40
@christianvluu
Copy link
Collaborator

Doesn't work for me when I run with roslaunch buggy sim_2d_2buggies.launch.

What file and I supposed to run? Or what command?

Are we supposed to use X11 for the tkinter window? X11 is quite nasty for cross-platform stuff, the first version of the sim was X11 based and it was quite cumbersome to get working.

@Jackack
Copy link
Collaborator

Jackack commented Feb 7, 2024

After resolving X11 issues, was able to test on MacOS by just running the launch files. I'll put in a PR for the link to the tutorial later.

The GUI module works fine, but please edit the launch files so that the UI updater isn't run at the same time as Patrick's checkpoint-based updater. You can do this by adding a command line argument to the launch file and casing on. it, see: https://wiki.ros.org/roslaunch/XML#if_and_unless_attributes

Or, just make two versions of each of sim_2d_single/2buggies files.

Copy link
Collaborator

@Jackack Jackack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment at line 120 of engine.py

rb_ws/src/buggy/scripts/auton/autonsystem.py Show resolved Hide resolved
rb_ws/src/buggy/scripts/2d_sim/velocity_ui.py Show resolved Hide resolved
rb_ws/src/buggy/scripts/auton/autonsystem.py Outdated Show resolved Hide resolved
rb_ws/src/buggy/scripts/auton/autonsystem.py Outdated Show resolved Hide resolved
rb_ws/src/buggy/scripts/2d_sim/engine.py Outdated Show resolved Hide resolved
@TiaSinghania TiaSinghania requested a review from Jackack February 7, 2024 22:37
Copy link
Collaborator

@Jackack Jackack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leggo

@TiaSinghania TiaSinghania merged commit 061e952 into main Feb 8, 2024
3 checks passed
@TiaSinghania TiaSinghania deleted the sw/ui_velocity branch February 8, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants