-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sw/UI velocity #38
Sw/UI velocity #38
Conversation
Basic framework of VelocityUpdater class, just applies constant acceleration to the buggy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
A few questions:
- How do we use this? Can you update the readme/instructions?
- Might be a good idea to have the velocities display in the tk window too.
- Label the tk windows for each individual buggy?
- Check necessary imports?
Just realized I accidentally used my other git account for the review... whoops (vluu23 is me) |
Also please pull in the most recent changes from the main branch (there's CI stuff in there which will help with readability). |
Doesn't work for me when I run with What file and I supposed to run? Or what command? Are we supposed to use X11 for the tkinter window? X11 is quite nasty for cross-platform stuff, the first version of the sim was X11 based and it was quite cumbersome to get working. |
After resolving X11 issues, was able to test on MacOS by just running the launch files. I'll put in a PR for the link to the tutorial later. The GUI module works fine, but please edit the launch files so that the UI updater isn't run at the same time as Patrick's checkpoint-based updater. You can do this by adding a command line argument to the launch file and casing on. it, see: https://wiki.ros.org/roslaunch/XML#if_and_unless_attributes Or, just make two versions of each of sim_2d_single/2buggies files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment at line 120 of engine.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leggo
Added another subclass for Controller that launches a tkinter window. Allows user to use up and down arrow keys to increase and decrease the published velocity from 0 to 30 in increments of 0.1.