fix: lab value display #2931
Merged
fix: lab value display #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmcgrath13
commented
Nov 19, 2024
mcmcgrath13
requested review from
BobanL,
angelathe,
lina-roth,
gordonfarrell,
JNygaard-Skylight and
austin-hall-skylight
and removed request for
angelathe
BobanL
requested changes
Nov 21, 2024
Co-authored-by: Boban <[email protected]>
Co-authored-by: Boban <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Allow lab values to pass through as html more generally. This enables formatting to be preserved.
It turned into a bit of a bigger rabbit hole than I hoped to do this in a way that felt safe and not too hacky. I introduced a new
RenderableNodetype that is a subset ofReact.ReactNodethat better reflects the data at hand. This cuts down the number of branches for typescript to complain about (and also for my head to hold).I also moved parsing into
sanitizeAndMapas they were always used in conjunction. This is now namedsafeParseand does some extra handling on the output to ensure we have aRenderableNodeand not the broaderReactNode.Related Issue
Fixes #2728
Fixes #2932
Additional Information