Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaks in Lab comments and narratives #2082

Closed
angelathe opened this issue Jul 8, 2024 · 3 comments · Fixed by #2148
Closed

Fix breaks in Lab comments and narratives #2082

angelathe opened this issue Jul 8, 2024 · 3 comments · Fixed by #2148
Labels
🐛 bug Something isn't working medium Medium-priority issues needs design review The PR for this issue will need design review before merging Streamline eCR Issues for Streamline eCR team to work on

Comments

@angelathe
Copy link
Collaborator

Action Requested

Lab comments and narratives currently do not maintain the original breaks/newlines, making it more difficult to read.
As a user, I want to see the breaks that separate the text so that it’s easier to read.

Acceptance Criteria

GIVEN an eCR with lab info
WHEN a lab result has a narrative and/or comment(s)
THEN the viewer should keep the original spacing/new lines of the text.

What should be changed:

  • Lab Info → Components table → Lab Comments (if available)
  • Lab Info → Narrative (if available)

Testing

Test fixtures, snapshot, and other unit tests may need to be updated.

Designs

Figma designs

NOTE From Sarah: Even if the original has too many breaks between text, we would rather have all the breaks than none at all.

Background & Context

Examples below from 61f13d32-b25c-4fb6-998b-73de2dbf87f2 (Link to eCR viewer)

Example: Lab Comments (see: Hepatitis C IgG w/Rfx PCR)
image.png

Example: Lab Narrative (see: FISH ALL PnL)
image.png

@angelathe angelathe added needs design review The PR for this issue will need design review before merging Streamline eCR Issues for Streamline eCR team to work on labels Jul 8, 2024
@gordonfarrell
Copy link
Collaborator

Look at Nick's recent PR #2049 for Labs for a similar situation

@sarahtress
Copy link
Collaborator

opening this ticket up again because it still seems to not be showing line breaks

@sarahtress sarahtress added the 🐛 bug Something isn't working label Aug 5, 2024
@emmastephenson emmastephenson added the medium Medium-priority issues label Sep 20, 2024
@mcmcgrath13
Copy link
Collaborator

This was fixed in #2931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working medium Medium-priority issues needs design review The PR for this issue will need design review before merging Streamline eCR Issues for Streamline eCR team to work on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants