Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a basic Sign In page #80

Merged
merged 17 commits into from
Nov 1, 2024
Merged

Build a basic Sign In page #80

merged 17 commits into from
Nov 1, 2024

Conversation

katyasoup
Copy link
Collaborator

@katyasoup katyasoup commented Oct 28, 2024

PULL REQUEST

Summary

  • Add a Sign In button to the header component
  • Add /signin page that displays a basic username/password form
    • Hide the Sign In and Data Usage Policy buttons on this page only
    • Hide the Sign In button on /query page as well
  • Show error state for incorrect username/password (currently triggers on submit when one or both fields are blank)
  • Redirect to /query from Sign In page on button click (regardless of form data)
  • Add dropdown menu and gear icon to query page
  • Return to landing page when clicking "Log out" from dropdown menu

Related Issue

Fixes #77

Acceptance Criteria

GIVEN the Query Connector landing page
WHEN a user clicks "Sign In"
THEN they are redirected to the /signin page

GIVEN the Query Connector /signin page
WHEN a user clicks Sign In
THEN they are redirected to /query

Note for designers: The data usage policy button wasn't included in the Figma mockup; happy to adjust its placement as needed/desired!

Screenshot 2024-10-29 at 13 17 35 Screenshot 2024-10-29 at 13 29 37

Additional Information

  • Dropdown menu gets wonky at smaller screen widths; didn't address for now since the footer could use some work in that area as well
  • The username/password fields will accept any string; if one or both are blank it will trigger the error state
  • The dropdown menu item "My queries" is commented out for now
  • We probably want to discuss using HTTPS if we're going to start handling account data

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@fzhao99 fzhao99 requested review from fzhao99 and removed request for fzhao99 October 29, 2024 13:58
Copy link
Collaborator

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks so much for putting this together so quickly

Worth tagging Michelle as well for a design review ☺️

query-connector/src/app/query/components/header/header.tsx Outdated Show resolved Hide resolved
query-connector/src/app/signin/page.tsx Outdated Show resolved Hide resolved
@katyasoup katyasoup requested a review from mikang October 29, 2024 18:29
Copy link
Collaborator

@robertandremitchell robertandremitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! one open q, but no other issues

Copy link
Collaborator

@DanPaseltiner DanPaseltiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! only blocking because I think as team we need to evaluate our use of "use client"

query-connector/src/app/signin/page.tsx Show resolved Hide resolved
Copy link
Collaborator

@bamader bamader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and wow y'all work fast!

Copy link
Collaborator

@DanPaseltiner DanPaseltiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking this PR. Nice work @katyasoup!

We can continue discussing SSR vs CSR in Slack.

@mikang
Copy link
Collaborator

mikang commented Oct 30, 2024

Thanks @katyasoup ! This looks great. Could you please make these changes?

  • Remove the lefthand blue image at the 768px breakpoint
  • Stack the footer text on two lines at the 960px breakpoint (right now, they overlap)

I was trying to review the error state, and it seems like I am able to log in with any credential. Is that just because it doesn't work yet?

Is that what this means?

Redirect to /query from Sign In page on button click (regardless of form data)

Also, log out takes me to 404. Also not sure if that's intentional.

image

@katyasoup
Copy link
Collaborator Author

Thanks @katyasoup ! This looks great. Could you please make these changes?

  • Remove the lefthand blue image at the 768px breakpoint
  • Stack the footer text on two lines at the 960px breakpoint (right now, they overlap)

I was trying to review the error state, and it seems like I am able to log in with any credential. Is that just because it doesn't work yet?

Is that what this means?

Redirect to /query from Sign In page on button click (regardless of form data)

Also, log out takes me to 404. Also not sure if that's intentional.

@mikang thanks! I'll add in the error state styles (but you are correct, that line about redirecting to /query just means any (or no) credential will work).

For the breakpoints - happy to add those here, though I wonder if it's worth capturing it in a new ticket? There are other areas that could use some adjustment as well to be more responsive. Can bring this up at standup, too :)

@mikang
Copy link
Collaborator

mikang commented Nov 1, 2024

Awesome @katyasoup !!! The responsiveness is great, and I also see the error states.

Could you please make these changes?

  • 24px vertical whitespace between Username and Password
  • 32px vertical whitespace between Password and the Sign In button

Could you also please change the font? This is my fault — I didn't update the designs, sorry! I believe @fzhao99 may have already standardized this in your design system. I've updated the Figma file accordingly.

  • Headline ("Sign in to Query Connector") to be 32px Merriweather Bold (H1)
  • Text ("This workspace allows you to sign in with your organizational account.") to be 16px Public Sans Regular (Body Medium)

So it should look like this now:
Sign in from Figma

Thank you!!

@fzhao99
Copy link
Collaborator

fzhao99 commented Nov 1, 2024

Could you also please change the font? This is my fault — I didn't update the designs, sorry! I believe @fzhao99 may have already standardized this in your design system. I've updated the Figma file accordingly.

I can handle this piece once this PR goes in! We might even get it for free because of the way the styles are tokenized

@mikang
Copy link
Collaborator

mikang commented Nov 1, 2024

Woohoo!!! Awesome, thank you @fzhao99 !!!

@katyasoup katyasoup merged commit a037e21 into main Nov 1, 2024
5 checks passed
@katyasoup katyasoup deleted the kcd/77-login-page branch November 1, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Login Page
6 participants