Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Header and Footer responsive styles #110

Merged
merged 51 commits into from
Nov 5, 2024

Conversation

katyasoup
Copy link
Collaborator

@katyasoup katyasoup commented Nov 1, 2024

PULL REQUEST

Summary

  • Updates to Header:
    • Persist spacing at smaller widths
    • Dropdown menu persists styles at smaller widths
    • Dropdown menu collapses when clicking outside the element
  • Updates to Footer:
    • Stack text lines at smaller widths

Related Issue

Fixes #106
(Ticket created based off discussion here)

Additional Information

Used 64em breakpoint as that's where other built-in USWDS styles (ex. dropdown menu) changed

Checklist

  • Descriptive Pull Request title
  • Link to relevant issues
  • Provide necessary context for design reviewers

Copy link

linear bot commented Nov 1, 2024

Base automatically changed from bob/que-30-set-up-routing-to-get-to-query-building to main November 4, 2024 15:26
@katyasoup katyasoup marked this pull request as ready for review November 4, 2024 18:26
@katyasoup katyasoup requested review from fzhao99 and mikang November 4, 2024 18:26
@mikang
Copy link
Collaborator

mikang commented Nov 4, 2024

Responsiveness is great @katyasoup !

It looks like the image is no longer full height though. Is there a way to revert it back to full height while keeping the responsiveness?

image

@fzhao99
Copy link
Collaborator

fzhao99 commented Nov 4, 2024

It looks like the image is no longer full height though. Is there a way to revert it back to full height while keeping the responsiveness?

@mikang this was my fault! Put a fix up for it here

Copy link
Collaborator

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@katyasoup katyasoup merged commit 8211e77 into main Nov 5, 2024
5 checks passed
@katyasoup katyasoup deleted the kcd/que-51-update-header-footer-responsive-styles branch November 5, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Header/Footer to accommodate smaller screen widths
4 participants